mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: ak@linux.intel.com, linux-kernel@vger.kernel.org
Subject: [PATCH] [9/21] HWPOISON: Handle hardware poisoned pages in try_to_unmap
Date: Fri, 11 Sep 2009 20:48:38 +0200 (CEST)	[thread overview]
Message-ID: <20090911184838.24087B1757@basil.firstfloor.org> (raw)
In-Reply-To: <20090911848.933193846@firstfloor.org>


From: Andi Kleen <ak@linux.intel.com>

When a page has the poison bit set replace the PTE with a poison entry.
This causes the right error handling to be done later when a process runs
into it.

v2: add a new flag to not do that (needed for the memory-failure handler
later) (Fengguang)
v3: remove unnecessary is_migration_entry() test (Fengguang, Minchan)

Reviewed-by: Minchan Kim <minchan.kim@gmail.com>
Reviewed-by: Wu Fengguang <fengguang.wu@intel.com>
Signed-off-by: Andi Kleen <ak@linux.intel.com>

---
 include/linux/rmap.h |    1 +
 mm/rmap.c            |    9 ++++++++-
 2 files changed, 9 insertions(+), 1 deletion(-)

Index: linux/mm/rmap.c
===================================================================
--- linux.orig/mm/rmap.c
+++ linux/mm/rmap.c
@@ -820,7 +820,14 @@ static int try_to_unmap_one(struct page
 	/* Update high watermark before we lower rss */
 	update_hiwater_rss(mm);
 
-	if (PageAnon(page)) {
+	if (PageHWPoison(page) && !(flags & TTU_IGNORE_HWPOISON)) {
+		if (PageAnon(page))
+			dec_mm_counter(mm, anon_rss);
+		else
+			dec_mm_counter(mm, file_rss);
+		set_pte_at(mm, address, pte,
+				swp_entry_to_pte(make_hwpoison_entry(page)));
+	} else if (PageAnon(page)) {
 		swp_entry_t entry = { .val = page_private(page) };
 
 		if (PageSwapCache(page)) {
Index: linux/include/linux/rmap.h
===================================================================
--- linux.orig/include/linux/rmap.h
+++ linux/include/linux/rmap.h
@@ -93,6 +93,7 @@ enum ttu_flags {
 
 	TTU_IGNORE_MLOCK = (1 << 8),	/* ignore mlock */
 	TTU_IGNORE_ACCESS = (1 << 9),	/* don't age */
+	TTU_IGNORE_HWPOISON = (1 << 10),/* corrupted page is recoverable */
 };
 #define TTU_ACTION(x) ((x) & TTU_ACTION_MASK)
 

  parent reply	other threads:[~2009-09-11 18:48 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-11 18:48 [PATCH] [0/21] HWPOISON: Intro Andi Kleen
2009-09-11 18:48 ` [PATCH] [1/21] HWPOISON: Add page flag for poisoned pages Andi Kleen
2009-09-11 18:48 ` [PATCH] [2/21] HWPOISON: Export some rmap vma locking to outside world Andi Kleen
2009-09-11 18:48 ` [PATCH] [3/21] HWPOISON: Add support for poison swap entries v2 Andi Kleen
2009-09-11 18:48 ` [PATCH] [4/21] HWPOISON: Add new SIGBUS error codes for hardware poison signals Andi Kleen
2009-09-11 18:48 ` [PATCH] [5/21] HWPOISON: Add basic support for poisoned pages in fault handler v3 Andi Kleen
2009-09-11 18:48 ` [PATCH] [6/21] HWPOISON: Add various poison checks in mm/memory.c v2 Andi Kleen
2009-09-11 18:48 ` [PATCH] [7/21] HWPOISON: x86: Add VM_FAULT_HWPOISON handling to x86 page fault handler v2 Andi Kleen
2009-09-11 18:48 ` [PATCH] [8/21] HWPOISON: Use bitmask/action code for try_to_unmap behaviour Andi Kleen
2009-09-11 18:48 ` Andi Kleen [this message]
2009-09-11 18:48 ` [PATCH] [10/21] HWPOISON: check and isolate corrupted free pages v2 Andi Kleen
2009-09-11 18:48 ` [PATCH] [11/21] HWPOISON: Refactor truncate to allow direct truncating of page v2 Andi Kleen
2009-09-11 18:48 ` [PATCH] [12/21] HWPOISON: Add invalidate_inode_page Andi Kleen
2009-09-11 18:48 ` [PATCH] [13/21] HWPOISON: Define a new error_remove_page address space op for async truncation Andi Kleen
2009-09-11 18:48 ` [PATCH] [14/21] HWPOISON: shmem: call set_page_dirty() with locked page Andi Kleen
2009-09-11 20:24   ` Peter Zijlstra
2009-09-11 21:56     ` Andi Kleen
2009-09-11 18:48 ` [PATCH] [15/21] HWPOISON: Add PR_MCE_KILL prctl to control early kill behaviour per process Andi Kleen
2009-09-11 18:48 ` [PATCH] [16/21] HWPOISON: The high level memory error handler in the VM v7 Andi Kleen
2009-09-11 19:25   ` Daniel Walker
2009-09-11 19:33     ` Andi Kleen
2009-09-11 19:38       ` Daniel Walker
2009-09-11 20:58       ` Daniel Walker
2009-09-11 21:57         ` Andi Kleen
2009-09-11 22:01           ` Daniel Walker
2009-09-11 18:48 ` [PATCH] [17/21] HWPOISON: Enable .remove_error_page for migration aware file systems Andi Kleen
2009-09-11 18:48 ` [PATCH] [18/21] HWPOISON: Enable error_remove_page for NFS Andi Kleen
2009-09-11 18:48 ` [PATCH] [19/21] HWPOISON: Add madvise() based injector for hardware poisoned pages v4 Andi Kleen
2009-09-11 18:48 ` [PATCH] [20/21] HWPOISON: Add simple debugfs interface to inject hwpoison on arbitary PFNs Andi Kleen
2009-09-11 18:48 ` [PATCH] [21/21] HWPOISON: Enable error_remove_page on btrfs Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090911184838.24087B1757@basil.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=ak@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®