From: Sam Ravnborg <sam@ravnborg.org>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Mike Frysinger <vapier.adi@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] kbuild: fix warning when domainname is not available
Date: Mon, 14 Sep 2009 06:46:57 +0200 [thread overview]
Message-ID: <20090914044657.GA4252@merkur.ravnborg.org> (raw)
In-Reply-To: <94a0d4530909131504h1a9de951k3719000705a86bbc@mail.gmail.com>
On Mon, Sep 14, 2009 at 01:04:11AM +0300, Felipe Contreras wrote:
> On Mon, Sep 14, 2009 at 12:58 AM, Mike Frysinger <vapier.adi@gmail.com> wrote:
> > .
> > On Sun, Sep 13, 2009 at 17:42, Felipe Contreras
> > <felipe.contreras@gmail.com> wrote:
> >> On Mon, Sep 14, 2009 at 12:12 AM, Mike Frysinger <vapier.adi@gmail.com> wrote:
> >>> On Sun, Sep 13, 2009 at 15:38, Felipe Contreras wrote:
> >>>> + if $domain; then
> >>>
> >>> is this really correct ? i think you meant to use:
> >>> [ -n "$domain" ]
> >>
> >> What is the difference?
> >>
> >> $domain unset
> >> test -n "" -> false
> >> test -> false
> >>
> >> $domain is a valid string
> >> test -n "string" -> true
> >> test "string" -> true
> >
> > except that you didnt invoke `test` anywhere. you're executing the
> > contents of $domain.
>
> Ahh, I'll update it to:
> [ "$domain" ]
Please use [ -n "$domain" ].
Be explicit about what you do.
[Likewise in c we never omit "int" just because we can].
Sam
next prev parent reply other threads:[~2009-09-14 4:46 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-13 19:38 [PATCH 0/5] Trivial warning cleanups Felipe Contreras
2009-09-13 19:38 ` [PATCH 1/5] Trivial whitespace cleanups Felipe Contreras
2009-09-13 19:38 ` [PATCH 2/5] kbuild: fix warning when domainname is not available Felipe Contreras
2009-09-13 19:38 ` [PATCH 3/5] kbuild: mkcompile_h: trivial cleanups Felipe Contreras
2009-09-13 19:38 ` [PATCH 4/5] acpi: fix trivial warning Felipe Contreras
2009-09-13 19:38 ` [PATCH 5/5] acpi: fix trivial warnings caused by previous commmit Felipe Contreras
2009-09-14 13:55 ` [PATCH 4/5] acpi: fix trivial warning Daniel Walker
2009-09-14 14:34 ` Felipe Contreras
2009-09-14 15:02 ` Daniel Walker
2009-11-12 0:23 ` Felipe Contreras
2009-11-13 17:43 ` Daniel Walker
2009-11-13 20:28 ` Felipe Contreras
2009-11-13 20:37 ` Thiago Farina
2009-11-15 17:15 ` Daniel Walker
2009-11-15 17:27 ` Felipe Contreras
2009-11-15 17:32 ` Daniel Walker
2009-11-15 17:54 ` Alexey Starikovskiy
2009-11-15 17:58 ` Daniel Walker
2009-11-15 18:10 ` Alexey Starikovskiy
2009-11-15 18:09 ` Daniel Walker
2009-11-16 1:27 ` Lin Ming
2009-09-13 21:12 ` [PATCH 2/5] kbuild: fix warning when domainname is not available Mike Frysinger
2009-09-13 21:42 ` Felipe Contreras
2009-09-13 21:58 ` Mike Frysinger
2009-09-13 22:04 ` Felipe Contreras
2009-09-14 4:46 ` Sam Ravnborg [this message]
2009-09-14 8:25 ` Felipe Contreras
2009-09-14 13:43 ` Mike Frysinger
2009-09-15 8:38 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090914044657.GA4252@merkur.ravnborg.org \
--to=sam@ravnborg.org \
--cc=felipe.contreras@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®