From: Jesse Barnes <jesse.barnes@intel.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Linux PCI <linux-pci@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
pm list <linux-pm@lists.linux-foundation.org>
Subject: Re: [Resend][PATCH 2/2] PCI PM: Return error codes from pci_pm_resume()
Date: Mon, 14 Sep 2009 13:42:10 -0700 [thread overview]
Message-ID: <20090914134210.3376e0f7@jbarnes-g45> (raw)
In-Reply-To: <200909092351.27178.rjw@sisk.pl>
On Wed, 9 Sep 2009 23:51:27 +0200
"Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> From: Rafael J. Wysocki <rjw@sisk.pl>
>
> Currently pci_pm_resume() always returns 0, which makes the error
> variable defined in there a bit pointless. Make pci_pm_resume()
> return error codes obtained from drivers' callbacks.
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> ---
> drivers/pci/pci-driver.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6/drivers/pci/pci-driver.c
> ===================================================================
> --- linux-2.6.orig/drivers/pci/pci-driver.c
> +++ linux-2.6/drivers/pci/pci-driver.c
> @@ -689,7 +689,7 @@ static int pci_pm_resume(struct device *
> pci_pm_reenable_device(pci_dev);
> }
>
> - return 0;
> + return error;
> }
>
> #else /* !CONFIG_SUSPEND */
>
Applied these two, thanks.
--
Jesse Barnes, Intel Open Source Technology Center
prev parent reply other threads:[~2009-09-14 20:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-09 21:49 [Resend][PATCH 1/2] PCI: Clear saved_state after the state has been restored Rafael J. Wysocki
2009-09-09 21:51 ` [Resend][PATCH 2/2] PCI PM: Return error codes from pci_pm_resume() Rafael J. Wysocki
2009-09-14 20:42 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090914134210.3376e0f7@jbarnes-g45 \
--to=jesse.barnes@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®