mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Jens Axboe <jens.axboe@oracle.com>,
	Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [origin tree build failure] [PATCH] block: remove blk_iopoll_enabled
Date: Tue, 15 Sep 2009 11:28:22 +0200	[thread overview]
Message-ID: <20090915092822.GA15538@elte.hu> (raw)
In-Reply-To: <20090913175902.GP14984@kernel.dk>


Note, upstream now breaks the build occasionally if CONFIG_BLOCK is 
disabled:

 kernel/built-in.o:(.data+0x17b0): undefined reference to `blk_iopoll_enabled'

Kamalesh Babulal posted a fix for that two weeks ago, i suspect it 
should be picked up - find it below.

	Ingo

-------------------->
>From 3b049b5e648ebfa508d52e9184d1c6c2cd456a72 Mon Sep 17 00:00:00 2001
From: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Date: Fri, 21 Aug 2009 16:41:13 +0530
Subject: [PATCH] block: remove blk_iopoll_enabled

* Jens Axboe <jens.axboe@oracle.com> [2009-08-07 21:21:44]:

> On Fri, Aug 07 2009, Randy Dunlap wrote:
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> >
> > New block-iopoll sysctl should be surrounded by CONFIG_BLOCK to
> > prevent build error:
> >
> > kernel/built-in.o:(.data+0x2990): undefined reference to `blk_iopoll_enabled'
>
> Thanks, I'll just kill off this sysctl, it should be driver controller
> anyway. Was just easier for testing :-)

This build failure is still seen with next-20090820 kernel, removing
the sysctl helps. Attaching the patch based on your recommendation.
Please drop the patch if you already have in queue.

Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: akpm <akpm@linux-foundation.org>
Cc: Jens Axboe <jens.axboe@oracle.com>
LKML-Reference: <20090821111113.GA5105@linux.vnet.ibm.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
--
 kernel/sysctl.c |    8 --------
 1 file changed, 8 deletions(-)
---
 kernel/sysctl.c |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)

diff --git a/kernel/sysctl.c b/kernel/sysctl.c
index 6bb59f7..95a1805 100644
--- a/kernel/sysctl.c
+++ b/kernel/sysctl.c
@@ -998,14 +998,6 @@ static struct ctl_table kern_table[] = {
 		.proc_handler	= &proc_dointvec,
 	},
 #endif
-	{
-		.ctl_name	= CTL_UNNUMBERED,
-		.procname	= "blk_iopoll",
-		.data		= &blk_iopoll_enabled,
-		.maxlen		= sizeof(int),
-		.mode		= 0644,
-		.proc_handler	= &proc_dointvec,
-	},
 /*
  * NOTE: do not add new entries to this table unless you have read
  * Documentation/sysctl/ctl_unnumbered.txt

  reply	other threads:[~2009-09-15  9:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-13 17:59 [GIT PULL] block bits for 2.6.32-rc1 Jens Axboe
2009-09-15  9:28 ` Ingo Molnar [this message]
2009-09-15 10:13   ` [origin tree build failure] [PATCH] block: remove blk_iopoll_enabled Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090915092822.GA15538@elte.hu \
    --to=mingo@elte.hu \
    --cc=jens.axboe@oracle.com \
    --cc=kamalesh@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome