From: David Miller <davem@davemloft.net>
To: tabbott@ksplice.com
Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org,
sam@ravnborg.org, geofft@ksplice.com
Subject: Re: [PATCH v2] sparc: Clean up linker script using new linker script macros.
Date: Wed, 16 Sep 2009 15:32:21 -0700 (PDT) [thread overview]
Message-ID: <20090916.153221.257687176.davem@davemloft.net> (raw)
In-Reply-To: <alpine.DEB.1.10.0909161332190.2942@dr-wily.mit.edu>
From: Tim Abbott <tabbott@ksplice.com>
Date: Wed, 16 Sep 2009 14:03:48 -0400 (EDT)
> On Wed, 16 Sep 2009, David Miller wrote:
>
>> It's hard for me to ACK this because it's not a straight nop
>> transformation, which we could at least presume would function
>> properly if the macros were implemented correctly.
>
> Would it help if I were to split the patch into first rearranging the code
> to look like the macros and then applying the macros, so that you can see
> more easily exactly what is changing?
No, it wouldn't :-) The issue is that I can't just say from
reading the patch that it will absolutely work.
But I'm willing to take the risk and we can revert if testing
shows it breaks things, so:
Acked-by: David S. Miller <davem@davemloft.net>
next prev parent reply other threads:[~2009-09-16 22:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-16 16:46 [PATCH v2] Linker script cleanup for sparc Tim Abbott
2009-09-16 16:46 ` [PATCH v2] sparc: Clean up linker script using new linker script macros Tim Abbott
2009-09-16 17:19 ` David Miller
2009-09-16 17:27 ` Tim Abbott
2009-09-16 17:30 ` David Miller
2009-09-16 18:03 ` Tim Abbott
2009-09-16 22:32 ` David Miller [this message]
2009-09-16 20:31 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090916.153221.257687176.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=geofft@ksplice.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=sparclinux@vger.kernel.org \
--cc=tabbott@ksplice.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®