mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Francois Romieu <romieu@fr.zoreil.com>
To: Andreas Mohr <andi@lisas.de>
Cc: Oliver Neukum <oliver@neukum.org>,
	Alan Stern <stern@rowland.harvard.edu>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	laurent.pinchart@skynet.be, Matthew Garrett <mjg59@srcf.ucam.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: usb autosuspend is history after S2R (also on 2.6.31; UVC?)
Date: Wed, 16 Sep 2009 21:51:56 +0200	[thread overview]
Message-ID: <20090916195156.GA30867@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <20090916181910.GA28260@rhlx01.hs-esslingen.de>

Andreas Mohr <andi@lisas.de> :
[...]
> Anyway, doesn't change the fact that the r8169 WOL PHY setting is toast
> after every S2R as well ;)

Stealth tester, he ?

diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
index 50c6a3c..e0af22f 100644
--- a/drivers/net/r8169.c
+++ b/drivers/net/r8169.c
@@ -3962,8 +3962,7 @@ static int rtl8169_resume(struct device *device)
 		goto out;
 
 	netif_device_attach(dev);
-
-	rtl8169_schedule_work(dev, rtl8169_reset_task);
+	netif_wake_queue(dev);
 out:
 	return 0;
 }

-- 
Ueimor

  reply	other threads:[~2009-09-16 19:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-15 18:51 Andreas Mohr
2009-09-15 19:00 ` Greg KH
2009-09-15 19:10   ` Matthew Garrett
2009-09-15 19:48 ` Oliver Neukum
2009-09-16 18:19   ` Andreas Mohr
2009-09-16 19:51     ` Francois Romieu [this message]
2009-09-16 19:54       ` Andreas Mohr
2009-09-16 20:43         ` Francois Romieu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090916195156.GA30867@electric-eye.fr.zoreil.com \
    --to=romieu@fr.zoreil.com \
    --cc=andi@lisas.de \
    --cc=gregkh@suse.de \
    --cc=laurent.pinchart@skynet.be \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=oliver@neukum.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®