From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux PCI <linux-pci@vger.kernel.org>,
pm list <linux-pm@lists.linux-foundation.org>
Subject: Re: [PATCH] PCI PM: Read device power state from register after updating it (rev. 2)
Date: Tue, 22 Sep 2009 21:51:35 +0200 [thread overview]
Message-ID: <200909222151.36022.rjw@sisk.pl> (raw)
In-Reply-To: <20090922091620.599ab046@infradead.org>
On Tuesday 22 September 2009, Arjan van de Ven wrote:
> On Mon, 21 Sep 2009 23:37:01 +0200
> "Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> >
> > - dev->current_state = state;
> > + pci_read_config_word(dev, dev->pm_cap + PCI_PM_CTRL, &pmcsr);
> > + dev->current_state = (pmcsr & PCI_PM_CTRL_STATE_MASK);
> > + /* Return error code if we have failed to change the state */
> > + if (dev->current_state != state)
> > + dev_info(&dev->dev, "Refused to change power state, "
> > + "currently in D%d\n", dev->current_state);
>
> I would suspect that you want this message only once...
> to avoid it flooding logs and such
Hmm? I don't think we use pci_set_power_state() _that_ often.
> or at least ratelimiting it
That sounds like a good idea, though, will respin.
next prev parent reply other threads:[~2009-09-22 19:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-21 21:37 Rafael J. Wysocki
2009-09-22 7:16 ` Arjan van de Ven
2009-09-22 19:51 ` Rafael J. Wysocki [this message]
2009-09-22 8:07 ` Andreas Mohr
2009-09-22 19:50 ` Rafael J. Wysocki
[not found] ` <7004b08e0909221256m6d917531kc8b51e1af85d3459@mail.gmail.com>
2009-09-22 20:39 ` Rafael J. Wysocki
2009-09-22 20:58 ` [PATCH] PCI PM: Read device power state from register after updating it (rev. 3) Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200909222151.36022.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=arjan@infradead.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®