mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Michael Abbott <michael@araneidae.co.uk>,
	Jan Engelhardt <jengelh@medozas.de>,
	Johan van Baarlen <jf@vanbaarlen.demon.nl>
Subject: [GIT PULL] cputime tree
Date: Thu, 24 Sep 2009 13:31:36 +0200	[thread overview]
Message-ID: <20090924133136.7b7c834e@mschwide.boeblingen.de.ibm.com> (raw)

Hi Linus,

with git commit 79741dd "idle cputime accounting" the semantic
of the stime field of the idle processes has changed. It used to
contain the amount of time the idle process has been scheduled.
Since git commit 79741dd is contains the cpu time spent in the
system by the idle process.

This change broke the output of second field of /proc/uptime. On
systems without VIRT_CPU_ACCOUNTING the field is always zero.
The legacy output of the field is the amount of time the idle
process has been scheduled on cpu #0. It is good enough to
calculate the load on an uni-processor system, it is useless
on a multi-processor. To restore the legacy behaviour and give
meaning to the multi-processor case the best we could come up
with is to add the idle time over all cpus. That fixes uni-
processors systems and gives a defined semantic on smp.

So please pull from 'cputime' branch of

	git://git390.marist.edu/pub/scm/linux-2.6.git cputime

to receive the following updates:

Michael Abbott (1):
      Fix idle time field in /proc/uptime

 fs/proc/uptime.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/fs/proc/uptime.c b/fs/proc/uptime.c
index 0c10a0b..766b1d4 100644
--- a/fs/proc/uptime.c
+++ b/fs/proc/uptime.c
@@ -4,13 +4,18 @@
 #include <linux/sched.h>
 #include <linux/seq_file.h>
 #include <linux/time.h>
+#include <linux/kernel_stat.h>
 #include <asm/cputime.h>
 
 static int uptime_proc_show(struct seq_file *m, void *v)
 {
 	struct timespec uptime;
 	struct timespec idle;
-	cputime_t idletime = cputime_add(init_task.utime, init_task.stime);
+	int i;
+	cputime_t idletime = cputime_zero;
+
+	for_each_possible_cpu(i)
+		idletime = cputime64_add(idletime, kstat_cpu(i).cpustat.idle);
 
 	do_posix_clock_monotonic_gettime(&uptime);
 	monotonic_to_bootbased(&uptime);

             reply	other threads:[~2009-09-24 11:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-24 11:31 Martin Schwidefsky [this message]
2009-09-24 16:51 ` Andrew Morton
2009-09-24 19:49   ` Michael Abbott
2009-10-01 22:31     ` [stable] " Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090924133136.7b7c834e@mschwide.boeblingen.de.ibm.com \
    --to=schwidefsky@de.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=jengelh@medozas.de \
    --cc=jf@vanbaarlen.demon.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael@araneidae.co.uk \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®