From: Ingo Molnar <mingo@elte.hu>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Fr?d?ric Weisbecker <fweisbec@gmail.com>,
Ulrich Drepper <drepper@redhat.com>,
linux kernel <linux-kernel@vger.kernel.org>,
linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf tools: Dont use openat()
Date: Thu, 24 Sep 2009 21:20:02 +0200 [thread overview]
Message-ID: <20090924192002.GB19225@elte.hu> (raw)
In-Reply-To: <4ABB767D.6080004@gmail.com>
* Eric Dumazet <eric.dumazet@gmail.com> wrote:
> Ingo Molnar a ?crit :
> > * Eric Dumazet <eric.dumazet@gmail.com> wrote:
> >
> >> Hi Ingo
> >>
> >> Here is a patch for perf.
> >
> > Applied, thanks Eric!
> >
> >> BTW, use of openat() is a nuisance, since many machines have old glibc
> >> (RHEL 4 Update 5 -> glibc-2.3.4-2.36 on my dev machine for example)
> >
> > We can certainly remove that reliance - wanna send a patch for it?
>
> Here it is
>
> Thanks
>
> [PATCH] perf tools: Dont use openat()
>
> openat() is still a young glibc facility, better to not use it
> in a non performance critical program (perf list)
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> ---
> tools/perf/util/parse-events.c | 49 ++++++++++++-------------------
> 1 files changed, 20 insertions(+), 29 deletions(-)
Applied, thanks Eric! I think it's also significant enough to be pushed
to 2.6.32.
Ingo
next prev parent reply other threads:[~2009-09-24 19:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-24 13:05 [PATCH] perf tools: fix buffer allocation Eric Dumazet
2009-09-24 13:12 ` Ingo Molnar
2009-09-24 13:13 ` Eric Dumazet
2009-09-24 13:39 ` [PATCH] perf tools: Dont use openat() Eric Dumazet
2009-09-24 19:20 ` Ingo Molnar [this message]
2009-09-24 19:25 ` [tip:perf/urgent] " tip-bot for Eric Dumazet
2009-09-24 21:07 ` [PATCH] " Ulrich Drepper
2009-09-24 21:50 ` Eric Dumazet
2009-09-26 15:01 ` Ingo Molnar
2009-09-24 13:16 ` [tip:perf/urgent] perf tools: Fix buffer allocation tip-bot for Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090924192002.GB19225@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=drepper@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®