From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Nicolas Pitre <nico@fluxnic.net>,
Catalin Marinas <catalin.marinas@arm.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Lennert Buytenhek <buytenh@marvell.com>,
Frans Pop <elendil@planet.nl>,
lkml <linux-kernel@vger.kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] make Linux bootable on ARM again
Date: Fri, 25 Sep 2009 21:34:17 +0100 [thread overview]
Message-ID: <20090925203417.GA19662@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <alpine.LFD.2.00.0909251613240.4997@xanadu.home>
On Fri, Sep 25, 2009 at 04:28:02PM -0400, Nicolas Pitre wrote:
> Commit 200b812d00 "Clear the exclusive monitor when returning from an
> exception" broke the vast majority of ARM systems in the wild which are
> still pre ARMv6. The kernel is crashing on the first occurrence of an
> exception due to the removal of the actual return instruction for them.
> Let's add it back.
Catalin, can you please test your changes more thoroughly in future
please?
>
> Signed-off-by: Nicolas Pitre <nico@marvell.com>
> ---
>
> diff --git a/arch/arm/kernel/entry-header.S b/arch/arm/kernel/entry-header.S
> index e17e3c3..ac34c0d 100644
> --- a/arch/arm/kernel/entry-header.S
> +++ b/arch/arm/kernel/entry-header.S
> @@ -83,6 +83,8 @@
> ldr r0, [sp]
> strex r1, r2, [sp] @ clear the exclusive monitor
> ldmib sp, {r1 - pc}^ @ load r1 - pc, cpsr
> +#else
> + ldmia sp, {r0 - pc}^ @ load r0 - pc, cpsr
> #endif
> .endm
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2009-09-25 20:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-25 18:39 arm: current mainline fails to boot on QNAP TS-109 Frans Pop
2009-09-25 19:50 ` Nicolas Pitre
2009-09-25 20:17 ` Frans Pop
2009-09-25 20:28 ` [PATCH] make Linux bootable on ARM again Nicolas Pitre
2009-09-25 20:34 ` Russell King - ARM Linux [this message]
2009-09-26 8:39 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090925203417.GA19662@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=buytenh@marvell.com \
--cc=catalin.marinas@arm.com \
--cc=elendil@planet.nl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nico@fluxnic.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®