From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752793AbZIZPF4 (ORCPT ); Sat, 26 Sep 2009 11:05:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752692AbZIZPFz (ORCPT ); Sat, 26 Sep 2009 11:05:55 -0400 Received: from one.firstfloor.org ([213.235.205.2]:48757 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752551AbZIZPFz (ORCPT ); Sat, 26 Sep 2009 11:05:55 -0400 Date: Sat, 26 Sep 2009 17:05:55 +0200 From: Andi Kleen To: Wu Fengguang Cc: Hugh Dickins , Andrew Morton , Nick Piggin , Andi Kleen , "linux-mm@kvack.org" , LKML Subject: Re: [RFC][PATCH] HWPOISON: remove the unsafe __set_page_locked() Message-ID: <20090926150555.GM30185@one.firstfloor.org> References: <20090926031537.GA10176@localhost> <20090926114806.GA12419@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090926114806.GA12419@localhost> User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > However we may well end up to accept the fact that "we just cannot do > hwpoison 100% correct", and settle with a simple and 99% correct code. I would prefer to avoid any oopses, but if they are unlikely enough and too hard to fix that's bearable. The race window here is certainly rather small. On the other hand if you cannot detect a difference in benchmarks I see no reason not to add the additional steps, as long as the code isn't complicated or ugly. These changes are neither. -Andi -- ak@linux.intel.com -- Speaking for myself only.