mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Johannes Weiner <hannes@cmpxchg.org>
To: Jaswinder Singh Rajput <jaswinder@kernel.org>
Cc: Johannes Weiner <jw@emlix.com>, Chris Zankel <chris@zankel.net>,
	"Robert P. J. Day" <rpjday@crashcourse.ca>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] xtensa: Remove unused CONFIG XTENSA_ISS_NETWORK and XTENSA_UNALIGNED_USER
Date: Sun, 27 Sep 2009 10:52:27 +0200	[thread overview]
Message-ID: <20090927085227.GA8022@cmpxchg.org> (raw)
In-Reply-To: <1253983999.4568.66.camel@ht.satnam>

On Sat, Sep 26, 2009 at 10:23:19PM +0530, Jaswinder Singh Rajput wrote:
> 
> Removed unused CONFIG XTENSA_ISS_NETWORK and XTENSA_UNALIGNED_USER from Kconfig and defconfigs
> 
> Reported-by: Robert P. J. Day <rpjday@crashcourse.ca>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
> Cc: Johannes Weiner <jw@emlix.com>
> Cc: Chris Zankel <chris@zankel.net>
> ---
>  arch/xtensa/Kconfig                 |   13 -------------
>  arch/xtensa/configs/iss_defconfig   |    2 --
>  arch/xtensa/configs/s6105_defconfig |    2 --
>  3 files changed, 0 insertions(+), 17 deletions(-)
> 
> diff --git a/arch/xtensa/Kconfig b/arch/xtensa/Kconfig
> index ebe228d..328d0dd 100644
> --- a/arch/xtensa/Kconfig
> +++ b/arch/xtensa/Kconfig
> @@ -83,15 +83,6 @@ config XTENSA_VARIANT_S6000
>  	select XTENSA_CALIBRATE_CCOUNT
>  endchoice
>  
> -config XTENSA_UNALIGNED_USER

The code refers to CONFIG_UNALIGNED_USER, so a rename would be better
instead of removing it.

> -	bool "Unaligned memory access in use space"
> -	help
> -	  The Xtensa architecture currently does not handle unaligned
> -	  memory accesses in hardware but through an exception handler.
> -	  Per default, unaligned memory accesses are disabled in user space.
> -
> -	  Say Y here to enable unaligned memory access in user space.
> -
>  config PREEMPT
>  	bool "Preemptible Kernel"
>  	help
> @@ -122,9 +113,6 @@ config XTENSA_CALIBRATE_CCOUNT
>  config SERIAL_CONSOLE
>  	def_bool n
>  
> -config XTENSA_ISS_NETWORK
> -	def_bool n
> -

That one is of no use in the mainline kernel.  I guess out-of-tree
code uses it.

>  menu "Bus options"
>  
>  config PCI
> @@ -150,7 +138,6 @@ config XTENSA_PLATFORM_ISS
>  	bool "ISS"
>  	select XTENSA_CALIBRATE_CCOUNT
>  	select SERIAL_CONSOLE
> -	select XTENSA_ISS_NETWORK
>  	help
>  	  ISS is an acronym for Tensilica's Instruction Set Simulator.
>  
> diff --git a/arch/xtensa/configs/iss_defconfig b/arch/xtensa/configs/iss_defconfig
> index f198540..e6c1a29 100644
> --- a/arch/xtensa/configs/iss_defconfig
> +++ b/arch/xtensa/configs/iss_defconfig

No need to edit auto-generated files.

      reply	other threads:[~2009-09-27  8:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-26 16:53 Jaswinder Singh Rajput
2009-09-27  8:52 ` Johannes Weiner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090927085227.GA8022@cmpxchg.org \
    --to=hannes@cmpxchg.org \
    --cc=chris@zankel.net \
    --cc=jaswinder@kernel.org \
    --cc=jw@emlix.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rpjday@crashcourse.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome