From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Ingo Molnar <mingo@elte.hu>
Cc: Len Brown <lenb@hera.kernel.org>,
torvalds@linux-foundation.org, akpm@linux-foundation.org,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [origin tree build failure] [PATCH] thinkpad-acpi: Fix build on !CONFIG_THINKPAD_ACPI_HOTKEY_POLL
Date: Sun, 27 Sep 2009 09:28:28 -0300 [thread overview]
Message-ID: <20090927122828.GA24783@khazad-dum.debian.net> (raw)
In-Reply-To: <20090927075254.GA20847@elte.hu>
On Sun, 27 Sep 2009, Ingo Molnar wrote:
> > drivers/platform/x86/thinkpad_acpi.c | 632 +++++++++++++++++++---------
>
> -tip testing found that these changes caused a build failure
> in drivers/platform/x86/thinkpad_acpi.c when
> !CONFIG_THINKPAD_ACPI_HOTKEY_POLL - the fix is attached
> below.
Fixed by a different patch, which will hit mainline soon. Len already
merged the fix in acpi-test.
BTW, the function _is_ used even when CONFIG_THINKPAD_ACPI_HOTKEY_POLL is
undefined...
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
next prev parent reply other threads:[~2009-09-27 12:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-26 5:19 [git pull request] ACPI related patches for 2.6.32-rc0 - part 2 Len Brown
2009-09-27 7:52 ` [origin tree build failure] [PATCH] thinkpad-acpi: Fix build on !CONFIG_THINKPAD_ACPI_HOTKEY_POLL Ingo Molnar
2009-09-27 12:28 ` Henrique de Moraes Holschuh [this message]
2009-09-28 3:34 ` Len Brown
2009-09-28 15:35 ` Ingo Molnar
2009-09-28 19:44 ` Henrique de Moraes Holschuh
2009-10-01 9:57 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090927122828.GA24783@khazad-dum.debian.net \
--to=hmh@hmh.eng.br \
--cc=akpm@linux-foundation.org \
--cc=lenb@hera.kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®