From: Arnd Bergmann <arnd@arndb.de>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Greg KH <gregkh@suse.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty: fix vt_compat_ioctl
Date: Tue, 29 Sep 2009 14:49:46 +0200 [thread overview]
Message-ID: <200909291449.46371.arnd@arndb.de> (raw)
In-Reply-To: <m2tyymho45.fsf@igel.home>
On Monday 28 September 2009, Andreas Schwab wrote:
> Greg KH <gregkh@suse.de> writes:
>
> > On Mon, Sep 28, 2009 at 08:10:02PM +0200, Andreas Schwab wrote:
> >> Call compat_unimap_ioctl, not do_unimap_ioctl.
> >
> > That's a nice description of what the patch does, but why do we need to
> > do that?
>
> It's a compat ioctl handler, so lets call the compat ioctl handler.
>
My bad, sorry.
I broke it in e9216651 evidently, thanks for debugging this.
The compat_unimap_ioctl was originally called do_unimap_ioctl in
fs/compat_ioctl.h which got moved to drivers/char/vt_ioctl.c.
In that patch, the caller was not updated and consequently called
the native handler.
Acked-by: Arnd Bergmann <arnd@arndb.de>
Arnd <><
prev parent reply other threads:[~2009-09-29 12:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-28 18:10 Andreas Schwab
2009-09-28 18:33 ` Greg KH
2009-09-28 19:21 ` Andreas Schwab
2009-09-28 23:56 ` Florian Mickler
2009-09-29 12:49 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200909291449.46371.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome