mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Joe Perches <joe@perches.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>
Subject: Re: [RFC] move #define pr_fmt KBUILD_MODNAME and KMSG_COMPONENT to Makefiles?
Date: Wed, 30 Sep 2009 08:55:33 +0200	[thread overview]
Message-ID: <20090930065533.GB13850@merkur.ravnborg.org> (raw)
In-Reply-To: <1254248104.28232.447.camel@Joe-Laptop.home>

Hi Joe.

On Tue, Sep 29, 2009 at 11:15:04AM -0700, Joe Perches wrote:
> There are starting to be more uses of
> 
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> 
> and
> 
> #define KMSG_COMPONENT "foo"
> #define pr_fmt(fmt) KMSG_COMPONENT ": " fmt
> 
> in kernel sources.
> 
> Perhaps it would be better to put these
> defines in the appropriate Makefile and not
> sprinkle the sources with them multiple times?

Maybe I'm a bit dense but I do not quiete follow you
here. What is it you want moved to kbuild here?

To me it looks more like a logical extension to the
pr_* macros based on info we already have available.

	Sam

  reply	other threads:[~2009-09-30  6:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-29 18:15 Joe Perches
2009-09-30  6:55 ` Sam Ravnborg [this message]
2009-09-30  7:54   ` Joe Perches
2009-09-30  9:20     ` Martin Schwidefsky
2009-09-30 14:52       ` Joe Perches
2009-10-01 11:02         ` Martin Schwidefsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090930065533.GB13850@merkur.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®