mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Tim Abbott <tabbott@ksplice.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Nelson Elhage <nelhage@ksplice.com>
Subject: Re: [PATCH 2/2] arm: Clean up linker script using new linker script macros.
Date: Thu, 1 Oct 2009 13:56:57 +0100	[thread overview]
Message-ID: <20091001125657.GA26910@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20090930213924.GB15732@merkur.ravnborg.org>

On Wed, Sep 30, 2009 at 11:39:25PM +0200, Sam Ravnborg wrote:
> On Wed, Sep 30, 2009 at 05:25:35PM -0400, Tim Abbott wrote:
> > From: Nelson Elhage <nelhage@ksplice.com>
> > 
> > This patch is mostly a straightforward translation. The primary side
> > effect to the resulting vmlinux should be to increase the alignment on
> > the initramfs to the standard PAGE_SIZE from 32 bytes.
> > 
> > Signed-off-by: Nelson Elhage <nelhage@ksplice.com>
> > Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> > Signed-off-by: Tim Abbott <tabbott@ksplice.com>
> > ---
> >  arch/arm/kernel/vmlinux.lds.S |   75 +++++++++++-----------------------------
> >  1 files changed, 21 insertions(+), 54 deletions(-)
> > 
> >  
> > -	.bss : {
> > -		__bss_start = .;	/* BSS				*/
> > -		*(.bss)
> > -		*(COMMON)
> > -		__bss_stop = .;
> > -		_end = .;
> 
> Where is _end in the new layout?
> I think we lost it.

You're right - this will cause a build failure since _end is used in
several core ARM files.  Tim?

PS, please ensure that all patches are at the very least build tested,
or say when they aren't.

  reply	other threads:[~2009-10-01 12:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-30 21:25 [PATCH v4 0/2] Linker script cleanup patches for arm Tim Abbott
2009-09-30 21:25 ` [PATCH 1/2] arm: convert to use __HEAD and HEAD_TEXT macros Tim Abbott
2009-09-30 21:31   ` Sam Ravnborg
2009-09-30 21:25 ` [PATCH 2/2] arm: Clean up linker script using new linker script macros Tim Abbott
2009-09-30 21:39   ` Sam Ravnborg
2009-10-01 12:56     ` Russell King - ARM Linux [this message]
2009-10-02 20:32       ` Tim Abbott
2009-10-02 20:32         ` [PATCH v4 1/2] arm: convert to use __HEAD and HEAD_TEXT macros Tim Abbott
2009-10-02 20:32         ` [PATCH v4 2/2] arm: Clean up linker script using new linker script macros Tim Abbott
2009-10-12 14:41           ` Tim Abbott
2009-10-13  8:50             ` Uwe Kleine-König
2009-10-13 16:47               ` Tim Abbott
  -- strict thread matches above, loose matches on Subject: below --
2009-07-31 20:56 [PATCH 1/2] arm: convert to use __HEAD and HEAD_TEXT macros Tim Abbott
2009-07-31 20:56 ` [PATCH 2/2] arm: Clean up linker script using new linker script macros Tim Abbott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091001125657.GA26910@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nelhage@ksplice.com \
    --cc=sam@ravnborg.org \
    --cc=tabbott@ksplice.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®