From: Konrad Rzeszutek <konrad@darnok.org>
To: Jeremy Fitzhardinge <Jeremy.Fitzhardinge@citrix.com>
Cc: Jan Beulich <JBeulich@novell.com>,
"ketuzsezr@darnok.org" <ketuzsezr@darnok.org>,
"pjones@redhat.com" <pjones@redhat.com>,
Martin Wilck <Martin.Wilck@fujitsu-siemens.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
alex.zeffertt@eu.citrix.com
Subject: Re: [PATCH] iSCSI/iBFT: use proper address translation
Date: Thu, 1 Oct 2009 21:28:06 -0400 [thread overview]
Message-ID: <20091002012806.GB27478@andromeda.dapyr.net> (raw)
In-Reply-To: <4AC5234C.5030409@citrix.com>
On Thu, Oct 01, 2009 at 02:46:52PM -0700, Jeremy Fitzhardinge wrote:
> On 10/01/09 01:01, Jan Beulich wrote:
> > In virtual environments (namely, Xen Dom0) virt <-> phys and
> > virt <-> isa-bus translations cannot be freely interchanged. When
> > looking at memory below 1M, the latter translations should always
> > be used.
> >
>
> Do you have a different definition for isa_virt_to_bus in your kernel?
> As far as I can see it is defined to be the same as virt_to_phys. Also,
> the ISA memory is identity mapped into the domain's physical mapping
> space, so it should be directly accessible without any problems.
The issue as I've come to understand is that the virt_to_phys on
memory below the 1MB does not work. Alex suggested another fix which
ioremap's the iBFT region, but I think this patch by Martin does the same job.
Either way, it looks good to me.
Signed-off-by: Konrad Rzeszutek Wilk <ketuzsezs@darnok.org>
next prev parent reply other threads:[~2009-10-02 1:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-01 8:01 Jan Beulich
2009-10-01 13:35 ` Peter Jones
2009-10-01 21:46 ` Jeremy Fitzhardinge
2009-10-02 1:28 ` Konrad Rzeszutek [this message]
2009-10-02 7:25 ` Jan Beulich
2009-10-02 14:32 ` Peter Jones
2009-10-02 14:58 ` Konrad Rzeszutek Wilk
2009-10-02 7:23 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091002012806.GB27478@andromeda.dapyr.net \
--to=konrad@darnok.org \
--cc=JBeulich@novell.com \
--cc=Jeremy.Fitzhardinge@citrix.com \
--cc=Martin.Wilck@fujitsu-siemens.com \
--cc=alex.zeffertt@eu.citrix.com \
--cc=ketuzsezr@darnok.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®