From: Greg KH <greg@kroah.com>
To: Bruce Jones <brucej97223@gmail.com>
Cc: gregkh@suse.de, devel@driverdev.osuosl.org, wfp5@virginia.edu,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: comedi: CodingStyle cleanup for drivers/acl722b.c
Date: Fri, 2 Oct 2009 15:16:36 -0700 [thread overview]
Message-ID: <20091002221636.GE32440@kroah.com> (raw)
In-Reply-To: <4AC12685.5030002@gmail.com>
On Mon, Sep 28, 2009 at 02:11:33PM -0700, Bruce Jones wrote:
> Cleanup this file as per the coding style. Adding KERN_INFO to
> the printks.
>
> Signed-off-by: Bruce Jones <brucej@linux.com>
> ---
> drivers/staging/comedi/drivers/acl7225b.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/acl7225b.c b/drivers/staging/comedi/drivers/acl7225b.c
> index c3652ef..e6c6c87 100644
> --- a/drivers/staging/comedi/drivers/acl7225b.c
> +++ b/drivers/staging/comedi/drivers/acl7225b.c
> @@ -94,7 +94,7 @@ static int acl7225b_attach(struct comedi_device *dev,
>
> iobase = it->options[0];
> iorange = this_board->io_range;
> - printk("comedi%d: acl7225b: board=%s 0x%04x ", dev->minor,
> + printk(KERN_INFO "comedi%d: acl7225b: board=%s 0x%04x ", dev->minor,
> this_board->name, iobase);
> if (!request_region(iobase, iorange, "acl7225b")) {
> printk("I/O port conflict\n");
> @@ -137,14 +137,14 @@ static int acl7225b_attach(struct comedi_device *dev,
> s->range_table = &range_digital;
> s->private = (void *)ACL7225_DI_LO;
>
> - printk("\n");
> + printk(KERN_INFO "\n");
Oh nevermind, I took your later patch, sorry for the confusion.
greg k-h
prev parent reply other threads:[~2009-10-02 23:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-28 21:11 Bruce Jones
2009-10-02 22:11 ` Greg KH
2009-10-02 22:16 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091002221636.GE32440@kroah.com \
--to=greg@kroah.com \
--cc=brucej97223@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=wfp5@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome