mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: david@fries.net
Cc: hancockrwd@gmail.com, linux-kernel@vger.kernel.org,
	d.stussy@yahoo.com, joao.ramos@inov.pt, torvalds@osdl.org,
	rjw@sisk.pl, vojtech@suse.cz
Subject: Re: [bisected] 2.6.31 regression sis5513 PIO Mode 0 hang
Date: Sun, 04 Oct 2009 20:58:48 -0700 (PDT)	[thread overview]
Message-ID: <20091004.205848.109978798.davem@davemloft.net> (raw)
In-Reply-To: <20091005025549.GA32331@spacedout.fries.net>

From: David Fries <david@fries.net>
Date: Sun, 4 Oct 2009 21:55:50 -0500

> First, if I'm going to do much debugging, how would I force the
> ethernet device to come up first so I have netconsole?
> 
> How is the problem patch,
> +       ide_port_for_each_dev(i, drive, hwif) {
> +               if (port_ops && port_ops->set_pio_mode)
> +                       port_ops->set_pio_mode(drive, 0);
> +       }
> 
> Different from using hdparm to set the mode?  I do this,
> hdparm -p 0 /dev/hda
> hdparm -X pio0 /dev/hda
> and the benchmarks give me about what I would expect 7MB/s instead of
> the normal 40MB/s.
> 
> Then I can re-enable with,
> hdparm -p 4 /dev/hda
> hdparm -X udma5 /dev/hda
> hdparm -d 1 /dev/hda
> hda: UDMA/100 mode selected
> and the drive is back up to speed, and obviously the kernel didn't
> freeze.  Should there be anything different between what the patch
> tried, and and hdparm's doing, other than kernel initiated and start
> and a user program later on?

>From your original hang trace I can only guess that the problematic
sequence is putting your CDROM into PIO0, then putting it into
PIO4, and then immediately reading the TOC.

This is what the ide-cd.c code does right about where you get the
hang.

Debugging this further is really totally pointless for a subsystem
that should be in deep maintainence mode, so I'm just going to
revert.

Thanks.

  reply	other threads:[~2009-10-05  3:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-03  2:54 David Fries
     [not found] ` <328926.65135.qm@web84205.mail.re3.yahoo.com>
2009-10-03 13:01   ` David Fries
2009-10-04  0:57 ` Robert Hancock
2009-10-05  2:55   ` David Fries
2009-10-05  3:58     ` David Miller [this message]
2009-10-06  4:06       ` David Fries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091004.205848.109978798.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=d.stussy@yahoo.com \
    --cc=david@fries.net \
    --cc=hancockrwd@gmail.com \
    --cc=joao.ramos@inov.pt \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=torvalds@osdl.org \
    --cc=vojtech@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®