mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: "Jayson R. King" <dev@jaysonking.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Jiri Kosina <trivial@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sched: Remove obsolete comment in sched_init()
Date: Mon, 5 Oct 2009 12:02:03 +0200	[thread overview]
Message-ID: <20091005100203.GA3211@elte.hu> (raw)
In-Reply-To: <4AC98F4A.7070303@jaysonking.com>


* Jayson R. King <dev@jaysonking.com> wrote:

> Remove the comment about calling alloc_bootmem() as it is not called
> here since commit 36b7b6d465489c4754c4fd66fcec6086eba87896.
>
> Signed-off-by: Jayson R. King <dev@jaysonking.com>
> ---
>  kernel/sched.c |    4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/kernel/sched.c b/kernel/sched.c
> index 1535f38..d68ac0e 100644
> --- a/kernel/sched.c
> +++ b/kernel/sched.c
> @@ -9334,10 +9334,6 @@ void __init sched_init(void)
>  #ifdef CONFIG_CPUMASK_OFFSTACK
>         alloc_size += num_possible_cpus() * cpumask_size();
>  #endif
> -       /*
> -        * As sched_init() is called before page_alloc is setup,
> -        * we use alloc_bootmem().
> -        */
>         if (alloc_size) {
>                 ptr = (unsigned long)kzalloc(alloc_size, GFP_NOWAIT);

Looks good. The patch is whitespace damaged though (all tabs are spaces) 
- please consult Documentation/email-clients.txt and resend the patch.

Thanks,

	Ingo

  reply	other threads:[~2009-10-05 10:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-05  6:16 Jayson R. King
2009-10-05 10:02 ` Ingo Molnar [this message]
2009-10-05 10:21   ` Jayson R. King
2009-10-05 19:26     ` Jayson R. King
2009-10-05 19:39     ` [tip:sched/core] " tip-bot for Jayson R. King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091005100203.GA3211@elte.hu \
    --to=mingo@elte.hu \
    --cc=dev@jaysonking.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome