From: "K.Prasad" <prasad@linux.vnet.ibm.com>
To: Paul Mundt <lethal@linux-sh.org>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Frederic Weisbecker <fweisbec@gmail.com>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH -tip] x86: hw-breakpoints: Actually flush thread breakpoints in flush_thread().
Date: Mon, 5 Oct 2009 16:19:55 +0530 [thread overview]
Message-ID: <20091005104955.GA14852@in.ibm.com> (raw)
In-Reply-To: <20091005102306.GA7889@linux-sh.org>
On Mon, Oct 05, 2009 at 07:23:06PM +0900, Paul Mundt wrote:
> [ I noticed this whilst hacking up SH support, applies to the current
> tracing/hw-breakpoints topic branch. ]
>
> flush_thread() tries to do a TIF_DEBUG check before calling in to
> flush_thread_hw_breakpoint() (which subsequently clears the thread flag),
> but for some reason, the x86 code is manually clearing TIF_DEBUG
> immediately before the test, so this path will never be taken.
>
> This kills off the erroneous clear_tsk_thread_flag() and lets
> flush_thread_hw_breakpoint() actually get invoked.
>
Yes, this is wrong and we missed it. Thanks for fixing!
> Presumably folks were getting lucky with testing and the
> free_thread_info() -> free_thread_xstate() path was taking care of the
> flush there.
>
> Signed-off-by: Paul Mundt <lethal@linux-sh.org>
Acked-by: K.Prasad <prasad@linux.vnet.ibm.com>
next prev parent reply other threads:[~2009-10-05 10:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-05 10:23 Paul Mundt
2009-10-05 10:49 ` K.Prasad [this message]
2009-10-09 3:40 ` Paul Mundt
2009-10-09 7:53 ` Frederic Weisbecker
2009-10-17 23:42 ` Frederic Weisbecker
2009-10-18 6:25 ` Paul Mundt
2009-10-18 16:43 ` Frederic Weisbecker
2009-10-19 19:48 ` Frederic Weisbecker
2009-10-19 23:24 ` Paul Mundt
2009-10-20 7:49 ` Frederic Weisbecker
2009-11-21 13:36 ` [tip:perf/core] x86/hw-breakpoints: " tip-bot for Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091005104955.GA14852@in.ibm.com \
--to=prasad@linux.vnet.ibm.com \
--cc=fweisbec@gmail.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome