From: Tilman Schmidt <tilman@imap.cc>
To: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Hansjoerg Lipp <hjlipp@web.de>,
Karsten Keil <isdn@linux-pingi.de>,
Karsten Keil <keil@b1-systems.de>,
isdn4linux@listserv.isdn4linux.de,
i4ldeveloper@listserv.isdn4linux.de
Subject: [PATCH 07/11] gigaset: correct debugging output selection
Date: Wed, 7 Oct 2009 00:18:56 +0200 (CEST) [thread overview]
Message-ID: <20091006-patch-gigaset-07.tilman@imap.cc> (raw)
In-Reply-To: <20091006-patch-gigaset-00.tilman@imap.cc>
Dump payload data consistently only when DEBUG_STREAM_DUMP debug bit
is set.
Impact: debugging aid
Signed-off-by: Tilman Schmidt <tilman@imap.cc>
---
drivers/isdn/gigaset/isocdata.c | 9 ++++++---
1 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/isdn/gigaset/isocdata.c b/drivers/isdn/gigaset/isocdata.c
index bed38fc..7fd32f0 100644
--- a/drivers/isdn/gigaset/isocdata.c
+++ b/drivers/isdn/gigaset/isocdata.c
@@ -429,7 +429,7 @@ static inline int hdlc_buildframe(struct isowbuf_t *iwb,
return -EAGAIN;
}
- dump_bytes(DEBUG_STREAM, "snd data", in, count);
+ dump_bytes(DEBUG_STREAM_DUMP, "snd data", in, count);
/* bitstuff and checksum input data */
fcs = PPP_INITFCS;
@@ -448,7 +448,6 @@ static inline int hdlc_buildframe(struct isowbuf_t *iwb,
/* put closing flag and repeat byte for flag idle */
isowbuf_putflag(iwb);
end = isowbuf_donewrite(iwb);
- dump_bytes(DEBUG_STREAM_DUMP, "isowbuf", iwb->data, end + 1);
return end;
}
@@ -482,6 +481,8 @@ static inline int trans_buildframe(struct isowbuf_t *iwb,
}
gig_dbg(DEBUG_STREAM, "put %d bytes", count);
+ dump_bytes(DEBUG_STREAM_DUMP, "snd data", in, count);
+
write = iwb->write;
do {
c = bitrev8(*in++);
@@ -583,7 +584,7 @@ static inline void hdlc_done(struct bc_state *bcs)
procskb->tail -= 2;
gig_dbg(DEBUG_ISO, "%s: good frame (%d octets)",
__func__, procskb->len);
- dump_bytes(DEBUG_STREAM,
+ dump_bytes(DEBUG_STREAM_DUMP,
"rcv data", procskb->data, procskb->len);
bcs->hw.bas->goodbytes += procskb->len;
gigaset_rcv_skb(procskb, bcs->cs, bcs);
@@ -878,6 +879,8 @@ static inline void trans_receive(unsigned char *src, unsigned count,
dobytes--;
}
if (dobytes == 0) {
+ dump_bytes(DEBUG_STREAM_DUMP,
+ "rcv data", skb->data, skb->len);
gigaset_rcv_skb(skb, bcs->cs, bcs);
bcs->skb = skb = dev_alloc_skb(SBUFSIZE + HW_HDR_LEN);
if (!skb) {
--
1.6.2.1.214.ge986c
next prev parent reply other threads:[~2009-10-06 22:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-06 22:18 [PATCH 00/11] Gigaset driver patches for 2.6.32 (v3) Tilman Schmidt
2009-10-06 22:18 ` [PATCH 01/11] gigaset: fix reject/hangup handling Tilman Schmidt
2009-10-06 22:18 ` [PATCH 02/11] gigaset: linearize skb Tilman Schmidt
2009-10-06 22:18 ` [PATCH 03/11] gigaset: handle isoc frame errors more gracefully Tilman Schmidt
2009-10-06 22:18 ` [PATCH 04/11] gigaset: announce if built with debugging Tilman Schmidt
2009-10-06 22:18 ` [PATCH 05/11] gigaset: fix device ERROR response handling Tilman Schmidt
2009-10-06 22:18 ` [PATCH 06/11] gigaset: improve error recovery Tilman Schmidt
2009-10-06 22:18 ` Tilman Schmidt [this message]
2009-10-06 22:19 ` [PATCH 08/11] gigaset: add kerneldoc comments Tilman Schmidt
2009-10-06 22:19 ` [PATCH 09/11] gigaset: prepare for CAPI implementation Tilman Schmidt
2009-10-06 22:19 ` [PATCH 10/11] gigaset: allow building without I4L Tilman Schmidt
2009-10-06 22:19 ` [PATCH 11/11] gigaset: add Kernel CAPI interface (v3) Tilman Schmidt
2009-10-07 6:39 ` [PATCH 00/11] Gigaset driver patches for 2.6.32 (v3) David Miller
[not found] ` <1254904188.9411@nb-hp>
2009-10-07 8:30 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091006-patch-gigaset-07.tilman@imap.cc \
--to=tilman@imap.cc \
--cc=davem@davemloft.net \
--cc=hjlipp@web.de \
--cc=i4ldeveloper@listserv.isdn4linux.de \
--cc=isdn4linux@listserv.isdn4linux.de \
--cc=isdn@linux-pingi.de \
--cc=keil@b1-systems.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome