From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Amit Kucheria <amit.kucheria@verdurent.com>,
List Linux Kernel <linux-kernel@vger.kernel.org>,
List Linux Omap <linux-omap@vger.kernel.org>,
Lauri Leukkunen <lauri.leukkunen@nokia.com>,
Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH] input: fix rx51 board keymap
Date: Mon, 5 Oct 2009 22:06:56 -0700 [thread overview]
Message-ID: <20091006050656.GI27881@core.coreip.homeip.net> (raw)
In-Reply-To: <20090930184843.GQ16865@atomide.com>
On Wed, Sep 30, 2009 at 11:48:44AM -0700, Tony Lindgren wrote:
> * Amit Kucheria <amit.kucheria@verdurent.com> [090930 06:26]:
> > The original driver was written with the KEY() macro defined as (col, row)
> > instead of (row, col) as defined by the matrix keypad infrastructure. So the
> > keymap was defined accordingly.
> >
> > Since the driver that was merged upstream uses the matrix keypad
> > infrastructure, modify the keymap accordingly.
> >
> > While we are at it, fix the comments in twl4030.h and define PERSISTENT_KEY as
> > (r,c) instead of (c, r)
> >
> > Tested on a RX51 (N900) device.
> >
> > Signed-off-by: Amit Kucheria <amit.kucheria@verdurent.com>
> > Cc: Tony Lindgren <tony@atomide.com>
> > Cc: Lauri Leukkunen <lauri.leukkunen@nokia.com>
> > Cc: Samuel Ortiz <sameo@linux.intel.com>
>
> Acked-by: Tony Lindgren <tony@atomide.com>
>
> Dimitry, will you queue this one?
>
> I'll also add it into omap-fixes-testing while waiting for it
> to go to mainline.
>
Applied to the 'for-linus' branch.
--
Dmitry
prev parent reply other threads:[~2009-10-06 5:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-30 13:25 Amit Kucheria
2009-09-30 18:48 ` Tony Lindgren
2009-10-06 5:06 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091006050656.GI27881@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=amit.kucheria@verdurent.com \
--cc=lauri.leukkunen@nokia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®