From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Mark Allyn <mark.a.allyn@intel.com>
Cc: linux-kernel@vger.kernel.org, alan@linux.intel.com,
greg@kroah.com, charles.f.johnson@intel.com,
Mark Allyn <mark.a.allyn@intel.com>
Subject: Re: [PATCH] Changes to integrate RAR with SEP and fix RAR problems
Date: Tue, 6 Oct 2009 23:22:17 +0100 [thread overview]
Message-ID: <20091006232217.18e3f0f4@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1254861953-18099-1-git-send-email-mark.a.allyn@intel.com>
> @@ -121,7 +121,7 @@ source "drivers/staging/hv/Kconfig"
>
> source "drivers/staging/vme/Kconfig"
>
> -source "drivers/staging/rar/Kconfig"
> +source "drivers/staging/rar_register/Kconfig"
Its impossible to compare changes in diffs if you move them around and
then diff them. Please don't do that. Produce the diffs using the same
directory - it can move anyway when the thing comes out of staging
If you must move something then do the move and the changes as two
separate patches so it is clear. You do seem to have also done things
like reformatted the code, or worked off an old tree not the kernel one
for the changes which isn't helpful.
prev parent reply other threads:[~2009-10-06 22:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-06 20:45 Mark Allyn
2009-10-06 21:29 ` Greg KH
2009-10-06 22:22 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091006232217.18e3f0f4@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=alan@linux.intel.com \
--cc=charles.f.johnson@intel.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.a.allyn@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®