From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: akpm@linux-foundation.org, Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org
Subject: Re: [patch 0/4] DEBUG_RCU_HEAD: Debug and fix racy call_rcu() users
Date: Tue, 6 Oct 2009 21:20:54 -0700 [thread overview]
Message-ID: <20091007042054.GE6838@linux.vnet.ibm.com> (raw)
In-Reply-To: <20091006143727.868480435@polymtl.ca>
On Tue, Oct 06, 2009 at 10:37:28AM -0400, Mathieu Desnoyers wrote:
> Here is a patchset, done on 2.6.30.9, which permits to detect and fix racy
> call_rcu() users.
>
> Fix for vunmap, which happens to be one of them, is included.
>
> Note that some false-positives might come up when call_rcu() is called on
> uninitialized struct rcu_head. The solution is, surprisingly enough, to
> initialize them.
Very cool, Mathieu!!!
I do like adding the debug-only field to struct rcu_head. Lots of
additional places need initialization, or am I missing a trick here?
Thanx, Paul
next prev parent reply other threads:[~2009-10-07 4:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-06 14:37 Mathieu Desnoyers
2009-10-06 14:37 ` [patch 1/4] kernel call_rcu usage: initialize rcu_head structures Mathieu Desnoyers
2009-10-06 15:19 ` [patch 1/4] kernel call_rcu usage: initialize rcu_head structures (v2) Mathieu Desnoyers
2009-10-06 14:37 ` [patch 2/4] tree rcu: Add debug RCU head option Mathieu Desnoyers
2009-10-06 15:54 ` Eric Dumazet
2009-10-06 16:09 ` Mathieu Desnoyers
2009-10-06 16:17 ` Eric Dumazet
2009-10-06 16:35 ` Mathieu Desnoyers
2009-10-06 14:37 ` [patch 3/4] markers call_rcu usage: initialize rcu_head structures Mathieu Desnoyers
2009-10-06 14:37 ` [patch 4/4] vunmap: Fix racy use of rcu_head Mathieu Desnoyers
2009-10-06 15:23 ` Mathieu Desnoyers
2009-10-06 16:43 ` Christoph Lameter
2009-10-06 17:33 ` Mathieu Desnoyers
2009-10-07 4:20 ` Paul E. McKenney [this message]
2009-10-07 12:36 ` [patch 0/4] DEBUG_RCU_HEAD: Debug and fix racy call_rcu() users Mathieu Desnoyers
2009-10-12 18:07 ` Ingo Molnar
2009-10-12 18:30 ` Mathieu Desnoyers
2009-10-12 18:37 ` Ingo Molnar
2009-10-12 18:56 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091007042054.GE6838@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome