mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ondrej Zary <linux@rainbow-software.org>
To: Gianluca Cecchi <gianluca.cecchi@gmail.com>
Cc: laurent.pinchart@skynet.be, linux-uvc-devel@lists.berlios.de,
	linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [Linux-uvc-devel] [PATCH] Re: uvcvideo: Finally fix Logitech  Quickcam for Notebooks Pro
Date: Wed, 7 Oct 2009 15:34:54 +0200	[thread overview]
Message-ID: <200910071534.55687.linux@rainbow-software.org> (raw)
In-Reply-To: <561c252c0910070612v6c7f6363xbb9548f62c834fbd@mail.gmail.com>

On Wednesday 07 October 2009, Gianluca Cecchi wrote:
> On Wed, Oct 7, 2009 at 2:59 PM, Ondrej Zary 
<linux@rainbow-software.org>wrote:
> > [snip]
> >
> > > What was the change that supposedly broke this in 2.6.22?
> >
> > I discovered that it's not related to usb audio at all. Doing "rmmod
> > uvcvideo"
> > and "modprobe uvcvideo" repeatedly succeeded after a couple of tries.
> > Increasing
> > UVC_CTRL_STREAMING_TIMEOUT to 3000 helped (2000 was not enough).
> >
> >
> > Increase UVC_CTRL_STREAMING_TIMEOUT to fix initialization of
> > Logitech Quickcam for Notebooks Pro.
> > This fixes following error messages:
> > uvcvideo: UVC non compliance - GET_DEF(PROBE) not supported. Enabling
> > workaround.
> > uvcvideo: Failed to query (129) UVC probe control : -110 (exp. 26).
> > uvcvideo: Failed to initialize the device (-5).
> >
> > Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
> >
> > --- linux-2.6.31-orig/drivers/media/video/uvc/uvcvideo.h       
> > 2009-09-10 00:13:59.000000000 +0200
> > +++ linux-2.6.31/drivers/media/video/uvc/uvcvideo.h     2009-10-07
> > 13:47:27.000000000 +0200
> > @@ -304,7 +304,7 @@
> >  #define UVC_MAX_STATUS_SIZE    16
> >
> >  #define UVC_CTRL_CONTROL_TIMEOUT       300
> > -#define UVC_CTRL_STREAMING_TIMEOUT     1000
> > +#define UVC_CTRL_STREAMING_TIMEOUT     3000
> >
> >  /* Devices quirks */
> >  #define UVC_QUIRK_STATUS_INTERVAL      0x00000001
> >
> >
> > --
> > Ondrej Zary
>
> Could this kind of fix also be useful in my case with Omnivision oem in
> Dell sp2208wfp monitor, in your opinion?
> See thread
> https://lists.berlios.de/pipermail/linux-uvc-devel/2008-February/003076.html
>
> incidentally at that time I was using Fedora 8 32bit with kernel
> 2.6.23.15-137.fc8 that indeed is post 2.6.22....

I don't know - try it. My patch is not related to 2.6.22 and usb-audio at all.

-- 
Ondrej Zary

  parent reply	other threads:[~2009-10-07 13:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-06 14:07 Ondrej Zary
2009-10-07 12:59 ` [PATCH] " Ondrej Zary
     [not found]   ` <561c252c0910070612v6c7f6363xbb9548f62c834fbd@mail.gmail.com>
2009-10-07 13:34     ` Ondrej Zary [this message]
2009-10-08 23:04   ` [Linux-uvc-devel] " Laurent Pinchart
2009-10-09  6:32     ` Ondrej Zary
2009-10-11 22:01       ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200910071534.55687.linux@rainbow-software.org \
    --to=linux@rainbow-software.org \
    --cc=gianluca.cecchi@gmail.com \
    --cc=laurent.pinchart@skynet.be \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-uvc-devel@lists.berlios.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome