From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Alexander Strakh <strakh@ispras.ru>
Cc: Jiri Slaby <jirislaby@gmail.com>,
Linux Kernlel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [BUG] isicom.c sleeping function called from invalid context
Date: Wed, 7 Oct 2009 15:54:32 +0100 [thread overview]
Message-ID: <20091007155432.7d76e04b@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <200910071715.14853.strakh@ispras.ru>
On Wed, 7 Oct 2009 17:15:14 +0000
Alexander Strakh <strakh@ispras.ru> wrote:
> KERNEL_VERSION: 2.6.31
> DESCRIBE:
> Driver drivers/char/isicom.c might sleep in atomic context, because it calls
> tty_port_xmit_buf under spin_lock.
>
> ./drivers/char/isicom.c:
> 1307 static void isicom_hangup(struct tty_struct *tty)
> 1308 {
> ...
> 1315 spin_lock_irqsave(&port->card->card_lock, flags);
> 1316 isicom_shutdown_port(port);
> ...
>
> Path to might_sleep macro from isicom_hangup:
> 1. isicom_hangup calls spin_lock_irqsave (drivers/char/isicom.c:1315) and then
> calls isicom_shutdown_port.
> 2. isiscom_shutdown_port calls tty_port_free_xmit_buf at
> drivers/char/isicom.c:906
> 3. tty_port_free_xmit_buf calls mutex_lock at srivers/char/tty_port:48
Ok that's fairly easy to fix once the tty_port_open patch is applied
prev parent reply other threads:[~2009-10-07 14:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-07 17:15 Alexander Strakh
2009-10-07 13:31 ` Alan Cox
2009-10-07 14:54 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091007155432.7d76e04b@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=strakh@ispras.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®