From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Alan Cox <alan@linux.intel.com>,
linux-kernel@vger.kernel.org, strakh@ispras.ru
Subject: Re: [PATCH 2/4] isicom: switch to the new tty_port_open helper
Date: Thu, 8 Oct 2009 14:13:53 +0100 [thread overview]
Message-ID: <20091008141353.342fd2ae@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <4ACCF5D5.7010505@gmail.com>
On Wed, 07 Oct 2009 22:11:01 +0200
Jiri Slaby <jirislaby@gmail.com> wrote:
> On 10/07/2009 04:46 PM, Alan Cox wrote:
> > - if (port->port.flags & ASYNC_INITIALIZED)
> > - return 0;
> > - if (tty_port_alloc_xmit_buf(&port->port) < 0)
> > + if (tty_port_alloc_xmit_buf(tport) < 0)
>
> I think this won't work well with 1/4. ->activate is called with
> port->port.mutex (the name in this context), but tty_port_alloc_xmit_buf
> wants it again.
Ok fixed that the simple way the buffer allocator now has its own private
mutex. Any other problems strike you ?
next prev parent reply other threads:[~2009-10-08 13:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-07 14:46 [PATCH 0/4] tty_port use for isicom Alan Cox
2009-10-07 14:46 ` [PATCH 1/4] tty_port: add "tty_port_open" helper Alan Cox
2009-10-07 14:46 ` [PATCH 2/4] isicom: switch to the new tty_port_open helper Alan Cox
2009-10-07 20:11 ` Jiri Slaby
2009-10-07 21:05 ` Alan Cox
2009-10-08 13:13 ` Alan Cox [this message]
2009-10-08 13:31 ` Jiri Slaby
2009-10-07 14:46 ` [PATCH 3/4] isicom: sort out the board init logic Alan Cox
2009-10-07 14:46 ` [PATCH 4/4] isicom: fix deadlock on shutdown Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091008141353.342fd2ae@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=alan@linux.intel.com \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=strakh@ispras.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®