From: Ingo Molnar <mingo@elte.hu>
To: Stephane Eranian <eranian@googlemail.com>
Cc: linux-kernel@vger.kernel.org, paulus@samba.org,
a.p.zijlstra@chello.nl, perfmon2-devel@lists.sf.net,
Stephane Eranian <eranian@gmail.com>
Subject: Re: [PATCH 2/2] perf_events: add event constraints support for Intel processors
Date: Fri, 9 Oct 2009 15:55:52 +0200 [thread overview]
Message-ID: <20091009135552.GA1695@elte.hu> (raw)
In-Reply-To: <1254840129-6198-3-git-send-email-eranian@gmail.com>
* Stephane Eranian <eranian@googlemail.com> wrote:
> +struct evt_cstr {
> + unsigned long idxmsk[BITS_TO_LONGS(X86_PMC_IDX_MAX)];
> + int code;
> +};
> +
> +#define EVT_CSTR0(c, m) { .code = (c), .idxmsk[0] = (m) }
> +#define EVT_CSTR_END { .code = 0, .idxmsk[0] = 0 }
> +
> +#define for_each_evt_cstr(e, c) \
> + for((e) = (c); (e)->idxmsk[0]; (e)++)
Nice patch - but the naming here absolutely sucked, so i changed
evt_cstr, idxmsk, CSTR, etc. to something more palatable. Field names
and abstractions in Linux code really need to be meaningful, and the
code has to be readable and understandable. Wdntusabbrntslkthtinlnx :)
Ingo
next prev parent reply other threads:[~2009-10-09 13:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-06 14:42 [PATCH 0/2] perf_events: correct event assignments on " Stephane Eranian
2009-10-06 14:42 ` [PATCH 1/2] perf_events: check for filters on fixed counter events Stephane Eranian
2009-10-06 14:42 ` [PATCH 2/2] perf_events: add event constraints support for Intel processors Stephane Eranian
2009-10-06 16:29 ` Peter Zijlstra
2009-10-06 17:26 ` stephane eranian
2009-10-06 18:57 ` [perfmon2] " Vince Weaver
2009-10-07 10:31 ` Peter Zijlstra
2009-10-07 11:15 ` Paul Mackerras
2009-10-07 12:31 ` stephane eranian
2009-10-07 20:46 ` David Miller
2009-10-07 21:30 ` stephane eranian
2009-10-08 20:08 ` Ingo Molnar
2009-10-08 20:28 ` stephane eranian
2009-10-12 9:05 ` Ingo Molnar
2009-10-13 7:17 ` stephane eranian
2009-10-13 7:29 ` Ingo Molnar
2009-10-08 23:18 ` Paul Mackerras
2009-10-09 14:22 ` [tip:perf/core] perf, x86: Add simple group validation tip-bot for Peter Zijlstra
2009-10-09 13:55 ` Ingo Molnar [this message]
2009-10-09 14:22 ` [tip:perf/core] perf_events: Add event constraints support for Intel processors tip-bot for Stephane Eranian
2009-10-09 14:22 ` [tip:perf/core] perf_events: Check for filters on fixed counter events tip-bot for Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091009135552.GA1695@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=eranian@gmail.com \
--cc=eranian@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=perfmon2-devel@lists.sf.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®