From: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, lenb@kernel.org
Subject: Re: [PATCH -mmotm] cmpc_acpi: depends on ACPI
Date: Sun, 11 Oct 2009 11:44:19 -0300 [thread overview]
Message-ID: <20091011144418.GF30257@vespa.holoscopio.com> (raw)
In-Reply-To: <20091009161036.7f752529.randy.dunlap@oracle.com>
[-- Attachment #1: Type: text/plain, Size: 1307 bytes --]
On Fri, Oct 09, 2009 at 04:10:36PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix about 100 build errors/warnings when ACPI is not enabled. E.g.:
>
> drivers/platform/x86/cmpc_acpi.c:50: error: dereferencing pointer to incomplete type
> drivers/platform/x86/cmpc_acpi.c:55: error: dereferencing pointer to incomplete type
> drivers/platform/x86/cmpc_acpi.c:56: error: dereferencing pointer to incomplete type
> drivers/platform/x86/cmpc_acpi.c:72: warning: 'struct acpi_device' declared inside parameter list
> drivers/platform/x86/cmpc_acpi.c:77: error: dereferencing pointer to incomplete type
> drivers/platform/x86/cmpc_acpi.c:79: error: dereferencing pointer to incomplete type
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Acked-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
> ---
> drivers/platform/x86/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- mmotm-2009-1009-0107.orig/drivers/platform/x86/Kconfig
> +++ mmotm-2009-1009-0107/drivers/platform/x86/Kconfig
> @@ -438,7 +438,7 @@ config ACPI_TOSHIBA
>
> config ACPI_CMPC
> tristate "CMPC Laptop Extras"
> - depends on X86
> + depends on X86 && ACPI
> select INPUT
> select BACKLIGHT_CLASS_DEVICE
> default n
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-10-11 15:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-09 8:07 mmotm 2009-10-09-01-07 uploaded akpm
2009-10-09 10:00 ` [was: mmotm 2009-10-09-01-07 uploaded] Jiri Slaby
2009-10-09 15:30 ` Randy Dunlap
2009-10-09 15:32 ` kvm build failure " Jiri Slaby
2009-10-09 23:15 ` Andrew Morton
2009-10-09 22:47 ` mmotm 2009-10-09-01-07 uploaded (b43) Randy Dunlap
2009-10-10 3:55 ` Larry Finger
2009-10-09 23:10 ` [PATCH -mmotm] cmpc_acpi: depends on ACPI Randy Dunlap
2009-10-11 14:44 ` Thadeu Lima de Souza Cascardo [this message]
2009-10-09 23:10 ` [PATCH -mmotm] synchro-test: add missing header file Randy Dunlap
2009-10-10 0:12 ` mmotm 2009-10-09-01-07 - iwl3945 fails to do firmware load request Valdis.Kletnieks
2009-10-10 0:42 ` Zhu Yi
2009-10-10 5:22 ` Valdis.Kletnieks
2009-10-12 10:51 ` [PATCH -mmotm] synchro-test: add missing header file David Howells
2009-10-12 23:20 ` Andrew Morton
2009-10-13 2:24 ` Stephen Rothwell
2009-10-13 2:33 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091011144418.GF30257@vespa.holoscopio.com \
--to=cascardo@holoscopio.com \
--cc=akpm@linux-foundation.org \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®