From: Ingo Molnar <mingo@elte.hu>
To: Arjan van de Ven <arjan@infradead.org>,
Mike Galbraith <efault@gmx.de>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf timechart: Work around commit 42e59d7d19dc4b4
Date: Mon, 12 Oct 2009 09:12:55 +0200 [thread overview]
Message-ID: <20091012071255.GB8202@elte.hu> (raw)
In-Reply-To: <20091007125601.415e7898@infradead.org>
* Arjan van de Ven <arjan@infradead.org> wrote:
> >From 07c039ee370f49a0c5fc690ba473d42d27ccb022 Mon Sep 17 00:00:00 2001
> From: Arjan van de Ven <arjan@linux.intel.com>
> Date: Wed, 7 Oct 2009 12:27:07 -0700
> Subject: [PATCH] perf timechart: Work around commit 42e59d7d19dc4b4
>
> Commit 42e59d7d19dc4b4 introduced a sample frequency framework..
> .. however it unfortunately changed how perf events get recorded,
> and caused timechart to miss events to the point that timechart
> became useless.
>
> This patch causes the timechart code to use -F 0 to not use the
> new framework when recording timechart data.
>
> Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
> ---
> tools/perf/builtin-timechart.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
Could you please check latest -tip, does it work fine now?
Mike's commit:
7e4ff9e: perf tools: Fix counter sample frequency breakage
should fix the breakage 42e59d7d19dc4b4 introduced in perf timechart.
Ingo
prev parent reply other threads:[~2009-10-12 7:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-07 19:56 Arjan van de Ven
2009-10-12 7:12 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091012071255.GB8202@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=arjan@infradead.org \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®