From: Ingo Molnar <mingo@elte.hu>
To: Arjan van de Ven <arjan@linux.intel.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
mingo@redhat.com, linux-kernel@vger.kernel.org,
torvalds@linux-foundation.org, arjan@infradead.org,
hmh@hmh.eng.br, rdreier@cisco.com, tglx@linutronix.de,
linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/pat] x86: Relegate CONFIG_PAT and CONFIG_MTRR configurability to EMBEDDED
Date: Mon, 12 Oct 2009 19:56:26 +0200 [thread overview]
Message-ID: <20091012175626.GA17138@elte.hu> (raw)
In-Reply-To: <4AD36B42.9060608@linux.intel.com>
* Arjan van de Ven <arjan@linux.intel.com> wrote:
> H. Peter Anvin wrote:
>> On 10/12/2009 04:10 AM, tip-bot for Arjan van de Ven wrote:
>>> Commit-ID: c03cb3149daed3e411657e3212d05ae27cf1a874
>>> Gitweb: http://git.kernel.org/tip/c03cb3149daed3e411657e3212d05ae27cf1a874
>>> Author: Arjan van de Ven <arjan@infradead.org>
>>> AuthorDate: Sun, 11 Oct 2009 10:33:02 -0700
>>> Committer: Ingo Molnar <mingo@elte.hu>
>>> CommitDate: Mon, 12 Oct 2009 13:06:57 +0200
>>>
>>> x86: Relegate CONFIG_PAT and CONFIG_MTRR configurability to EMBEDDED
>>>
>>> MTRR and PAT support (which got added to CPUs over 10 years ago)
>>> are no longer really optional in that more and more things are
>>> depending on PAT just working, including various drivers and newer
>>> versions of X. (to not even speak of MTRR)
>>>
>>> Having this as a regular config option just no longer makes sense.
>>>
>>> This patch relegates CONFIG_X86_PAT to the EMBEDDED category so
>>> ultra-embedded can still disable it if they really need to.
>>>
>>
>> Should we combine this with removing the whitelist (which is largely
>> vestigial at this point) and replace it with a blacklist (possibly
>> empty)? I still haven't seen any evidence that there are any CPUs
>> which have problems, and PAT support go back all the way to Pentium
>> III -- and page table attributes can be used all the way back to 386,
>> it just excludes the WC type.
>
> I would be in favor of that; other operating systems have been using
> pat everywhere since the pII days anyway.
Fine to me too. We only made it a whitelist to reduce the degrees of
freedom early in the implementation - it stuck around needlessly long.
Ingo
prev parent reply other threads:[~2009-10-12 17:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-11 15:43 [PATCH] x86: Relegate CONFIG_PAT " Arjan van de Ven
2009-10-11 17:04 ` Roland Dreier
2009-10-11 17:19 ` Robert Hancock
2009-10-11 17:33 ` Arjan van de Ven
2009-10-11 18:47 ` Henrique de Moraes Holschuh
2009-10-12 11:10 ` [tip:x86/pat] x86: Relegate CONFIG_PAT and CONFIG_MTRR configurability " tip-bot for Arjan van de Ven
2009-10-12 17:28 ` H. Peter Anvin
2009-10-12 17:45 ` Arjan van de Ven
2009-10-12 17:56 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091012175626.GA17138@elte.hu \
--to=mingo@elte.hu \
--cc=arjan@infradead.org \
--cc=arjan@linux.intel.com \
--cc=hmh@hmh.eng.br \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rdreier@cisco.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome