Re: 32-rc2: runtime_pm is noisy

[Pavel Machek <pavel@ucw.cz>]

On Tue 2009-10-06 23:42:20, Rafael J. Wysocki wrote:
> On Tuesday 06 October 2009, Pavel Machek wrote:
> > Hi!
> > 
> > Maybe it is my config,
> 
> Yes it is.
> 
> > but pm_runtime_idle is a bit too noisy on
> > zaurus... ok, I do have pm_debug & pm_verbose
> 
> Exactly.
> 
> > set... but still, is it useful to print message about devices that do not
> > support it?
> 
> It may be useful, because, for example, PCI can put devices without drivers
> into low power states using this mechanism.
> 
> Still, perhaps we can drop the debug messages from __pm_runtime_idle().
> 
> Care to send a patch?

Yep, something like this?

---

pm_runtime_idle is somewhat noisy. Remove debug prints.

Signed-off-by: Pavel Machek <pavel@ucw.cz>

--- a/drivers/base/power/runtime.c
+++ b/drivers/base/power/runtime.c
@@ -51,8 +51,6 @@ static int __pm_runtime_idle(struct device *dev)
 {
 	int retval = 0;
 
-	dev_dbg(dev, "__pm_runtime_idle()!\n");
-
 	if (dev->power.runtime_error)
 		retval = -EINVAL;
 	else if (dev->power.idle_notification)
@@ -93,8 +91,6 @@ static int __pm_runtime_idle(struct device *dev)
 	wake_up_all(&dev->power.wait_queue);
 
  out:
-	dev_dbg(dev, "__pm_runtime_idle() returns %d!\n", retval);
-
 	return retval;
 }
 

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html