From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1758129AbZJNISx@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758129AbZJNISx (ORCPT <rfc822;w@1wt.eu>);
	Wed, 14 Oct 2009 04:18:53 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756921AbZJNISw
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Wed, 14 Oct 2009 04:18:52 -0400
Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:39397
	"EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1752661AbZJNISu (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 14 Oct 2009 04:18:50 -0400
Date: Wed, 14 Oct 2009 01:18:46 -0700 (PDT)
Message-Id: <20091014.011846.39805804.davem@davemloft.net>
To: tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: Fix rio watchdog probe function
From: David Miller <davem@davemloft.net>
In-Reply-To: <alpine.LFD.2.00.0910101201470.9428@localhost.localdomain>
References: <alpine.LFD.2.00.0910101201470.9428@localhost.localdomain>
X-Mailer: Mew version 6.2.51 on Emacs 22.1 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Thomas Gleixner <tglx@linutronix.de>
Date: Sat, 10 Oct 2009 12:03:28 +0200 (CEST)

> After sucessfully registering the misc device the driver iounmaps the
> hardware registers and kfree's the device data structure. Ouch !
> 
> This was introduced with commit e42311d75 (riowatchdog: Convert to
> pure OF driver) and went unnoticed for more than a year :)
> 
> Return success instead of dropping into the error cleanup code path.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

Applied and queued up for -stable, thanks!