From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758859AbZJNL6T (ORCPT ); Wed, 14 Oct 2009 07:58:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756433AbZJNL6S (ORCPT ); Wed, 14 Oct 2009 07:58:18 -0400 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:37144 "EHLO www.etchedpixels.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754302AbZJNL6R (ORCPT ); Wed, 14 Oct 2009 07:58:17 -0400 Date: Wed, 14 Oct 2009 12:58:46 +0100 From: Alan Cox To: Linus Torvalds Cc: Paul Fulghum , Boyan , "Rafael J. Wysocki" , Linux Kernel Mailing List , Kernel Testers List , Dmitry Torokhov , Ed Tomlinson , "OGAWA Hirofumi \"" Subject: Re: [Bug #14388] keyboard under X with 2.6.31 Message-ID: <20091014125846.1a3c8d40@lxorguk.ukuu.org.uk> In-Reply-To: References: <56acieJJ2fF.A.nEB.Hzl0KB@chimera> <87ljjgfcbu.fsf@spindle.srvr.nix> <4AD3F769.5080405@gmail.com> <4AD437F9.9020708@yahoo.co.uk> <4AD4DE4C.4010402@yahoo.co.uk> <4AD4F548.2030506@microgate.com> <1255478932.19056.24.camel@localhost.localdomain> <4AD51D6B.7010509@microgate.com> X-Mailer: Claws Mail 3.7.2 (GTK+ 2.14.7; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Stop a moment. The code wasn't designed to permit two paralle calls of flush_to_ldisc to the same tty. That was always forbidden when that code was designed. It got broken because someone changed that rule recently (and because the locking was too clever) Alan