From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762167AbZJOWIB (ORCPT ); Thu, 15 Oct 2009 18:08:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758701AbZJOWIA (ORCPT ); Thu, 15 Oct 2009 18:08:00 -0400 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:40759 "EHLO www.etchedpixels.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758407AbZJOWH7 (ORCPT ); Thu, 15 Oct 2009 18:07:59 -0400 Date: Thu, 15 Oct 2009 23:08:53 +0100 From: Alan Cox To: Peter Stuge Cc: linux-kernel@vger.kernel.org Subject: Re: Hardware initialization in line discipline - ldisc_open() ? Message-ID: <20091015230853.44fb10c1@lxorguk.ukuu.org.uk> In-Reply-To: <20091015214642.6208.qmail@stuge.se> References: <20091015205803.30544.qmail@stuge.se> <20091015223137.6b9fb55a@lxorguk.ukuu.org.uk> <20091015214642.6208.qmail@stuge.se> X-Mailer: Claws Mail 3.7.2 (GTK+ 2.14.7; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 15 Oct 2009 23:46:42 +0200 Peter Stuge wrote: > Alan Cox wrote: > > > Can you suggest a solution to this problem? Ideally one that can be > > > contained in the ldisc. > > > > Similar problem with the GSM mux I've been working on. I've gone for > > making the ldisc attach always work and then kicking things off via an > > ioctl which sets the desired mode/parameters/encoding. > > I'll do the same. Did you add a new ioctl for this, or use an > existing one? I added a private one - given I needed to pass the adaption layer code, gsm mux level and whether we were initiator or not it didn't really fit anything generic in the tty layer.