From: Pavel Machek <pavel@ucw.cz>
To: Paul Fertser <fercerpav@gmail.com>
Cc: Anton Vorontsov <cbou@mail.ru>,
David Woodhouse <dwmw2@infradead.org>,
linux-kernel@vger.kernel.org,
Nelson Castillo <arhuaco@freaks-unidos.net>,
Balaji Rao <balajirrao@openmoko.org>
Subject: Re: [PATCH] power: pcf50633: introduces battery charging current control
Date: Sat, 17 Oct 2009 19:01:24 +0200 [thread overview]
Message-ID: <20091017170124.GB1526@ucw.cz> (raw)
In-Reply-To: <1255471148-29047-2-git-send-email-fercerpav@gmail.com>
Hi!
> From: Balaji Rao <balajirrao@openmoko.org>
Could we get some changelog here? Like 'it adds new file to sysfs
interface, ...'
> +static ssize_t
> +show_chglim(struct device *dev, struct device_attribute *attr, char *buf)
Could we get meaningful function names?
> @@ -31,6 +31,8 @@ struct pcf50633_platform_data {
>
> int charging_restart_interval;
>
> + int chg_ref_current_ma;
> +
...and variable names? This is also inconsistent with name above.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2009-10-18 18:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-13 21:59 [PATCH] power: pcf50633: add ac power supply class to the charger Paul Fertser
2009-10-13 21:59 ` [PATCH] power: pcf50633: introduces battery charging current control Paul Fertser
2009-10-13 21:59 ` [PATCH] gta02: set pcf50633 chg_ref_current_ma Paul Fertser
2009-10-13 21:59 ` [PATCH] power: pcf50633: get rid of charging restart software auto-triggering Paul Fertser
2009-10-13 21:59 ` [PATCH] power: pcf50633: properly reenable charging when the supply conditions change Paul Fertser
2009-10-13 21:59 ` [PATCH] power: pcf50633: query charger status directly Paul Fertser
2009-10-15 17:15 ` [PATCH] gta02: set pcf50633 chg_ref_current_ma Anton Vorontsov
2009-10-17 17:01 ` Pavel Machek [this message]
2009-10-20 0:01 ` [PATCH] power: pcf50633: introduces battery charging current control Paul Fertser
2009-10-20 7:26 ` Pavel Machek
2009-10-19 21:35 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091017170124.GB1526@ucw.cz \
--to=pavel@ucw.cz \
--cc=arhuaco@freaks-unidos.net \
--cc=balajirrao@openmoko.org \
--cc=cbou@mail.ru \
--cc=dwmw2@infradead.org \
--cc=fercerpav@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®