From: Peter Stuge <peter@stuge.se>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Hardware initialization in line discipline - ldisc_open() ?
Date: Sun, 18 Oct 2009 18:27:37 +0200 [thread overview]
Message-ID: <20091018162737.18611.qmail@stuge.se> (raw)
In-Reply-To: <20091015230853.44fb10c1@lxorguk.ukuu.org.uk>
Alan Cox wrote:
> > > Similar problem with the GSM mux I've been working on. I've gone for
> > > making the ldisc attach always work and then kicking things off via an
> > > ioctl which sets the desired mode/parameters/encoding.
> >
> > I'll do the same. Did you add a new ioctl for this, or use an
> > existing one?
>
> I added a private one - given I needed to pass the adaption layer code,
> gsm mux level and whether we were initiator or not it didn't really fit
> anything generic in the tty layer.
I was trying to reuse an existing ioctl, partly because I'm not sure
how to add a one and partly because fewer are better, but
TIOCSERCONFIG which seemed fitting does not appear to be passed on to
my ldisc. :\
Should I make a new one (what does private mean here btw?) and how do
I do it exactly? Is patching Documentation/ioctl/ioctl-number.txt and
asm/ioctls.h all? The "addressing" in ioctl-number seems a little
chaotic, do I just pick anything that is available?
//Peter
next prev parent reply other threads:[~2009-10-18 16:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-15 20:58 Peter Stuge
2009-10-15 21:31 ` Alan Cox
2009-10-15 21:46 ` Peter Stuge
2009-10-15 22:08 ` Alan Cox
2009-10-18 16:27 ` Peter Stuge [this message]
2009-10-18 22:33 ` Adding an ioctl or three Peter Stuge
2009-10-18 22:39 ` Randy Dunlap
2009-10-18 22:56 ` Peter Stuge
2009-10-21 17:32 ` [PATCH] docs: large update to ioctl-number.txt Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091018162737.18611.qmail@stuge.se \
--to=peter@stuge.se \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®