From: Jens Axboe <jens.axboe@oracle.com>
To: Changli Gao <xiaosuo@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: PATCH: sendfile() checks f_op.sendpage() instead of f_op.splice_write() wrongly
Date: Mon, 19 Oct 2009 10:25:56 +0200 [thread overview]
Message-ID: <20091019082556.GV20961@kernel.dk> (raw)
In-Reply-To: <4ADC1BAE.9060508@gmail.com>
On Mon, Oct 19 2009, Changli Gao wrote:
> sendfile(2) checks f_op.sendpage() instead of f_op.splice_write() wrongly.
>
> sendfile(2) was reworked with the splice infrastructure, but it still
> checks f_op.sendpage() instead of f_op.splice_write() wrongly. Although
> if f_op.sendpage() exists, f_op.splice_write() always exists at the same
> time currently, the assumption will be broken in future silently. This
> patch also brings a side effect: sendfile(2) can work with any output
> file, which supports splice_write() not only mmap(2).
Question is, if the check should just be dropped completely, since we
use fallback default handlers if the fs doesn't have
->splice_read/->splice_write().
--
Jens Axboe
next prev parent reply other threads:[~2009-10-19 8:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-19 7:56 Changli Gao
2009-10-19 8:25 ` Jens Axboe [this message]
2009-10-19 8:48 ` Changli Gao
2009-10-19 9:20 ` Changli Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091019082556.GV20961@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome