From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932178AbZJSOtg (ORCPT ); Mon, 19 Oct 2009 10:49:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932160AbZJSOte (ORCPT ); Mon, 19 Oct 2009 10:49:34 -0400 Received: from cam-admin0.cambridge.arm.com ([193.131.176.58]:36936 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932136AbZJSOtc (ORCPT ); Mon, 19 Oct 2009 10:49:32 -0400 Subject: [PATCH 2/4] kmemleak: Scan the _ftrace_events section in modules To: linux-kernel@vger.kernel.org From: Catalin Marinas Cc: Rusty Russell , Zdenek Kabelac Date: Mon, 19 Oct 2009 15:49:29 +0100 Message-ID: <20091019144928.14221.73541.stgit@pc1117.cambridge.arm.com> In-Reply-To: <20091019144602.14221.27128.stgit@pc1117.cambridge.arm.com> References: <20091019144602.14221.27128.stgit@pc1117.cambridge.arm.com> User-Agent: StGit/0.15-rc4 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 19 Oct 2009 14:49:29.0524 (UTC) FILETIME=[5C939740:01CA50CB] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This section contains pointers to allocated objects and not scanning it leads to false positives. Reported-by: Zdenek Kabelac Cc: Rusty Russell Signed-off-by: Catalin Marinas --- kernel/module.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/kernel/module.c b/kernel/module.c index 1eb9520..dd29ba4 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -2380,6 +2380,12 @@ static noinline struct module *load_module(void __user *umod, "_ftrace_events", sizeof(*mod->trace_events), &mod->num_trace_events); + /* + * This section contains pointers to allocated objects in the trace + * code and not scanning it leads to false positives. + */ + kmemleak_scan_area(mod->trace_events, sizeof(*mod->trace_events) * + mod->num_trace_events, GFP_KERNEL); #endif #ifdef CONFIG_FTRACE_MCOUNT_RECORD /* sechdrs[0].sh_size is always zero */