From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757917AbZJSVeV (ORCPT ); Mon, 19 Oct 2009 17:34:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757727AbZJSVeS (ORCPT ); Mon, 19 Oct 2009 17:34:18 -0400 Received: from g1t0027.austin.hp.com ([15.216.28.34]:19605 "EHLO g1t0027.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757869AbZJSVeQ (ORCPT ); Mon, 19 Oct 2009 17:34:16 -0400 Subject: [PATCH 2/5] mm: refactor register_cpu_under_node() To: akpm@linux-foundation.org From: Alex Chiang Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Date: Mon, 19 Oct 2009 15:34:20 -0600 Message-ID: <20091019213420.32729.45505.stgit@bob.kio> In-Reply-To: <20091019212740.32729.7171.stgit@bob.kio> References: <20091019212740.32729.7171.stgit@bob.kio> User-Agent: StGit/0.14.3.386.gb02d MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org By returning early if the node is not online, we can unindent the interesting code by one level. No functional change. Signed-off-by: Alex Chiang --- drivers/base/node.c | 20 +++++++++++--------- 1 files changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/base/node.c b/drivers/base/node.c index 3108b21..ef7dd22 100644 --- a/drivers/base/node.c +++ b/drivers/base/node.c @@ -227,16 +227,18 @@ struct node node_devices[MAX_NUMNODES]; */ int register_cpu_under_node(unsigned int cpu, unsigned int nid) { - if (node_online(nid)) { - struct sys_device *obj = get_cpu_sysdev(cpu); - if (!obj) - return 0; - return sysfs_create_link(&node_devices[nid].sysdev.kobj, - &obj->kobj, - kobject_name(&obj->kobj)); - } + struct sys_device *obj; - return 0; + if (!node_online(nid)) + return 0; + + obj = get_cpu_sysdev(cpu); + if (!obj) + return 0; + + return sysfs_create_link(&node_devices[nid].sysdev.kobj, + &obj->kobj, + kobject_name(&obj->kobj)); } int unregister_cpu_under_node(unsigned int cpu, unsigned int nid)