From: Jens Axboe <jens.axboe@oracle.com>
To: Corrado Zoccolo <czoccolo@gmail.com>
Cc: Linux-Kernel <linux-kernel@vger.kernel.org>,
Jeff Moyer <jmoyer@redhat.com>
Subject: Re: [RFC PATCH 3/5] cfq-iosched: reimplement priorities using different service trees
Date: Tue, 20 Oct 2009 15:19:16 +0200 [thread overview]
Message-ID: <20091020131916.GI10727@kernel.dk> (raw)
In-Reply-To: <4e5e476b0910200343s1d7913daq5719d8a4d84fb491@mail.gmail.com>
On Tue, Oct 20 2009, Corrado Zoccolo wrote:
> On Tue, Oct 20, 2009 at 2:58 AM, Jens Axboe <jens.axboe@oracle.com> wrote:
> > On Mon, Oct 19 2009, Corrado Zoccolo wrote:
> >> We use different service trees for different priority classes.
> >> This allows a simplification in the service tree insertion code, that no
> >> longer has to consider priority while walking the tree.
> >
> >> +enum wl_prio_t {
> >> + IDLE_WL = -1,
> >> + BE_WL = 0,
> >> + RT_WL = 1
> >> +};
> >
> > WL?
> It stands for "workload". When defining all-caps constants, one has to
> avoid possible clashes adding pre/suf-fixes.
> Any suggestion for better naming?
Nobody will guess that. Make variable/enum names as short as possible,
but not so short that their meaning are incomprehensible. Suggestion
would be to use IDLE_WORKLOAD etc.
--
Jens Axboe
prev parent reply other threads:[~2009-10-20 13:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-19 20:21 Corrado Zoccolo
2009-10-20 0:58 ` Jens Axboe
2009-10-20 10:43 ` Corrado Zoccolo
2009-10-20 13:19 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091020131916.GI10727@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=czoccolo@gmail.com \
--cc=jmoyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome