mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Thomas Renninger <trenn@suse.de>
Cc: linux-tip-commits@vger.kernel.org, linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] X86: Suppress hundreds of Intel thermal MCE messages on high temps
Date: Fri, 23 Oct 2009 10:01:53 +0200	[thread overview]
Message-ID: <20091023080153.GD10067@elte.hu> (raw)
In-Reply-To: <200910230200.37267.trenn@suse.de>


* Thomas Renninger <trenn@suse.de> wrote:

> This is against 2.6.31, but it should still patch, tell me if not. 
> Should this also go to stable@kernel.org?
> 
> Thanks,
> 
>        Thomas
> 
> ---------
> This (introduced by Ingo some time ago):
>    if (!(was_throttled ^ is_throttled) &&
>         time_before64(tmp_jiffs, __get_cpu_var(next_check)))
> does not help much.
> The interrupts happening and the read out MSR seem to tell that
> the CPU gets throttled and unthrottled all the time.
> Thus current implementation results in hundreds (thousands?) of "above threshold"
> messages per minute.
> 
> This patch is more or less a revert back to the implementation in
> older kernels.
> The message:
>     printk(KERN_INFO "CPU%d: Temperature/speed normal\n", cpu);
> is not needed as it is suppressed anyway.
> 
> Reference of an affected Core 2 and a Celeron machine:
> http://bugzilla.novell.com/show_bug.cgi?id=533556
> 
> Signed-off-by: Thomas Renninger <trenn@suse.de>

Have you seen these upstream commits:

 b417c9f: x86: mce: Fix thermal throttling message storm
 3967684: x86: mce: Clean up thermal throttling state tracking code

?

If they solve the problem for you then please forward them to 
stable@kernel.org.

Thanks,

	Ingo

           reply	other threads:[~2009-10-23  8:01 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <200910230200.37267.trenn@suse.de>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091023080153.GD10067@elte.hu \
    --to=mingo@elte.hu \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=trenn@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®