From: Ingo Molnar <mingo@elte.hu>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Dave Young <hidave.darkstar@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [RFC/PATCH] ratelimit: make output more useful
Date: Fri, 23 Oct 2009 15:11:14 +0200 [thread overview]
Message-ID: <20091023131114.GB27097@elte.hu> (raw)
In-Reply-To: <200910231458.11832.borntraeger@de.ibm.com>
* Christian Borntraeger <borntraeger@de.ibm.com> wrote:
> Am Freitag 23 Oktober 2009 13:33:48 schrieb Ingo Molnar:
> > Mind sending it against latest tip:master (or tip:core/printk):
> [...]
> > Which has a couple of ratelimit changes queued up already that collide
> > with your patch:
>
> Sure, something like the following?
>
> [PATCH] ratelimit: make output more useful
>
> Today I got
>
> [39648.224782] Registered led device: iwl-phy0::TX
> [40676.545099] __ratelimit: 246 callbacks suppressed
> [40676.545103] abcdef[23675]: segfault at 0 ...
btw., an effect of this will be a small amount of extra bloat at every
callsite of printk_ratelimit(). There's 200 of them kernel-wide, so i
guess it's OK as all these codepaths are atypical slowpaths already.
Ingo
next prev parent reply other threads:[~2009-10-23 13:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-19 15:06 Christian Borntraeger
2009-10-23 11:33 ` Ingo Molnar
2009-10-23 12:58 ` Christian Borntraeger
2009-10-23 13:11 ` Ingo Molnar [this message]
2009-10-23 14:51 ` Christian Borntraeger
2009-10-23 14:55 ` Ingo Molnar
2009-10-23 15:12 ` Christian Borntraeger
2009-10-23 21:17 ` Joe Perches
2009-10-24 1:04 ` [tip:branch?] ratelimit: Make suppressed output messages " tip-bot for Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091023131114.GB27097@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=borntraeger@de.ibm.com \
--cc=hidave.darkstar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®