From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Ike Panhc <ike.pan@canonical.com>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexandre Rostovtsev <tetromino@gmail.com>
Subject: Re: [Resend] [PATCH] ACPI: New driver for Lenovo SL laptops
Date: Fri, 23 Oct 2009 15:43:10 -0600 [thread overview]
Message-ID: <200910231543.12254.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <1256325108-22626-1-git-send-email-ike.pan@canonical.com>
On Friday 23 October 2009 01:11:48 pm Ike Panhc wrote:
> +static int __init lenovo_sl_laptop_init(void)
> +{
> + int ret;
> + acpi_status status;
> +
> + if (acpi_disabled)
> + return -ENODEV;
Don't need this.
> + lenovo_sl_laptop_hkey_handle = lenovo_sl_laptop_ec0_handle = NULL;
> + status = acpi_get_handle(NULL, ACPI_HKEY_PATH,
> + &lenovo_sl_laptop_hkey_handle);
> + if (ACPI_FAILURE(status)) {
> + pr_err("Failed to get ACPI handle for %s\n", ACPI_HKEY_PATH);
> + return -ENODEV;
> + }
Don't need this; acpi_bus_register_driver() is enough.
Bjorn
prev parent reply other threads:[~2009-10-23 21:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-24 15:12 Ike Panhc
2009-09-25 4:34 ` Dmitry Torokhov
2009-09-25 16:20 ` Alan Jenkins
2009-09-25 16:54 ` Alan Jenkins
2009-10-23 19:11 ` [Resend] " Ike Panhc
2009-10-23 19:18 ` Ike Panhc
2009-10-23 19:34 ` Alexey Starikovskiy
2009-10-23 19:57 ` Ike Panhc
2009-10-23 20:57 ` Alexey Starikovskiy
2009-10-23 21:43 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200910231543.12254.bjorn.helgaas@hp.com \
--to=bjorn.helgaas@hp.com \
--cc=ike.pan@canonical.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tetromino@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®