Re: [PATCH 2/7] ark3116: (3rd try) Make existing functions 16450-aware and add close and release functions.

[Oliver Neukum <oliver@neukum.org>]

Am Sonntag, 25. Oktober 2009 18:50:59 schrieb bart.hartgers@gmail.com:> +static void ark3116_close(struct usb_serial_port *port)> +{> +       struct usb_serial *serial = port->serial;>  > -       /* TEST ARK3116_SND(154, 0xFE, 0x40, 0xFFFF, 0x0006); */> +       /* disable DMA */> +       ark3116_write_reg(serial, UART_FCR, 0);>  > -       kfree(buf);> +       /* deactivate interrupts */> +       ark3116_write_reg(serial, UART_IER, 0);>  > -       return;> +       if (serial->dev) {> +               /* shutdown any bulk reads that might be going on */> +               if (serial->num_bulk_out)> +                       usb_kill_urb(port->write_urb);> +               if (serial->num_bulk_in)> +                       usb_kill_urb(port->read_urb);> +               if (serial->num_interrupt_in)> +                       usb_kill_urb(port->interrupt_in_urb);> +       }>  }
Why are the killings done on condition of serial-> != NULL but the registersare set unconditionally?
	Regards		Oliver
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿŸ\a«þG«éÿ¢ž?™šè­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢ž?–I¥