Re: [PATCH 1/4] strip: move driver to staging

[Pavel Machek <pavel@ucw.cz>]

On Mon 2009-10-26 12:55:19, John W. Linville wrote:
> On Fri, Oct 23, 2009 at 06:10:06PM +0200, Pavel Machek wrote:
> > On Tue 2009-10-20 14:17:07, John W. Linville wrote:
> > > Move the strip ("Starmode Radio IP") driver to drivers/staging.  For
> > > several years this driver has only seen API "bombing-run" changes, and
> > > few people ever had the hardware.  This driver represents unnecessary
> > > ongoing maintenance for no clear benefit.
> > 
> > This seems like abuse of the staging process.
> 
> My mailbox has been filling-up with discussions of using staging like
> this for the past few weeks.  I'm reasonably certain those threads
> were on the public lists.

Yes and I skimmed those.

> > There's no TODO to say what needs to be fixed. You just don't want to
> > maintain it. Because there's nothing to fix, noone has reason to patch
> > it, and the (working, good enough) driver will just be removed.
> 
> "ongoing maintenance for no clear benefit" -- that is what is wrong
> with it.

And how is moving to staging helping with that?

Anyway, for moving to staging, TODO file describing what needs to be
fixed before it is brought back was listed as a requirement. So it
looks like staging is wrong tool for the job.

> > What about removing it in the regular way, that's
> > Documentation/feature-removal.txt ?
> 
> This has been discussed recently as an alternative for unmaintained
> drivers.  I suspect this is better than adding a note to a file that
> no one reads...

There are other alternatives, like printk() in module_init...
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html