mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: mingo@elte.hu
Cc: lethal@linux-sh.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf tools: Kill off -Wcast-align
Date: Tue, 27 Oct 2009 17:59:40 -0700 (PDT)	[thread overview]
Message-ID: <20091027.175940.209239217.davem@davemloft.net> (raw)
In-Reply-To: <20091027135025.GC32628@elte.hu>

From: Ingo Molnar <mingo@elte.hu>
Date: Tue, 27 Oct 2009 14:50:25 +0100

> Generally if you run into such issues in Sparc let us know so we can fix 
> it :-)

Sorry, I wanted to do a thorough analysis to make sure I understood
why it was warning, but I was too busy to do so.

In the end the issue is the kernel list.h macros like list_entry(),
and it would similarly trigger for things like container_of().

If you have a pointer to a structure with objects other than "long
double" then cast it to a pointer to a structure that does have a
"long double" in it, this increases the alignment of the type (from 8
to 16 bytes on sparc 32-bit).

  reply	other threads:[~2009-10-28  0:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-26  5:40 Paul Mundt
2009-10-26  6:25 ` Ingo Molnar
2009-10-26  9:47   ` Paul Mundt
2009-10-26 10:08     ` Pekka Enberg
2009-10-26 11:21       ` Ingo Molnar
2009-10-26 22:40     ` David Miller
2009-10-27 13:50       ` Ingo Molnar
2009-10-28  0:59         ` David Miller [this message]
2009-10-26 11:38 ` [tip:perf/urgent] perf tools: Remove -Wcast-align tip-bot for Paul Mundt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091027.175940.209239217.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=lethal@linux-sh.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome