From: Ingo Molnar <mingo@elte.hu>
To: Tejun Heo <tj@kernel.org>
Cc: Jiri Kosina <jkosina@suse.cz>,
Peter Zijlstra <peterz@infradead.org>,
Jeff Mahoney <jeffm@suse.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
linux-ia64@vger.kernel.org
Subject: Re: [PATCH 1/2] percpu: allow pcpu_alloc() to be called with IRQs off
Date: Tue, 27 Oct 2009 14:04:07 +0100 [thread overview]
Message-ID: <20091027130407.GB32628@elte.hu> (raw)
In-Reply-To: <4AE6EDBF.7040905@kernel.org>
* Tejun Heo <tj@kernel.org> wrote:
> Jiri Kosina wrote:
> > pcpu_alloc() and pcpu_extend_area_map() perform a series of
> > spin_lock_irq()/spin_unlock_irq() calls, which make them unsafe
> > with respect to being called from contexts which have IRQs off.
> >
> > This patch converts the code to perform save/restore of flags instead,
> > making pcpu_alloc() (or __alloc_percpu() respectively) to be called
> > from early kernel startup stage, where IRQs are off.
> >
> > This is needed for proper initialization of per-cpu rq_weight data from
> > sched_init().
> >
> > Signed-off-by: Jiri Kosina <jkosina@suse.cz>
>
> Acked-by: Tejun Heo <tj@kernel.org>
>
> I'll wait for response on the series and push it through percpu#fixes
> tomorrow if there's no objection.
Yep, the 2/2 sched.c patch looks good now:
Acked-by: Ingo Molnar <mingo@elte.hu>
Ingo
next prev parent reply other threads:[~2009-10-27 13:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-27 12:32 Jiri Kosina
2009-10-27 12:55 ` Tejun Heo
2009-10-27 13:04 ` Ingo Molnar [this message]
2009-10-28 14:59 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091027130407.GB32628@elte.hu \
--to=mingo@elte.hu \
--cc=fenghua.yu@intel.com \
--cc=jeffm@suse.com \
--cc=jkosina@suse.cz \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tj@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®