mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
	mingo@redhat.com, hpa@zytor.com, paulus@samba.org,
	linux-kernel@vger.kernel.org, a.p.zijlstra@chello.nl,
	ink@jurassic.park.msu.ru, tglx@linutronix.de, rth@twiddle.net,
	mcree@orcon.net.nz, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:perf/core] perf tools, Alpha: Add Alpha support to perf.h
Date: Wed, 28 Oct 2009 21:58:44 +0100	[thread overview]
Message-ID: <20091028205844.GC20363@merkur.ravnborg.org> (raw)
In-Reply-To: <20091026122247.GA31982@elte.hu>

> > 
> > OK, I'll bite. We tell userspace developers not to include kernel 
> > headers. Why is it okay for perf to do it (especially for something 
> > that's in asm)?
> 
> The main counter-argument against inclusion was always "what if we break 
> them accidentally". I.e. it can become a semi-ABI - stuff we cannot 
> change because we cannot change the outside projects. With perf this 
> cannot occur - it's all in one Git tree and can always be fixed/changed.
> 
> Note that we reuse a couple of other facilities in tools/perf as well - 
> linux/list.h, rbtree.c, etc. - and this is good - you can code perf as 
> if you were hacking on the kernel! ;-)

I see no reasons why perf should not use the exported headers
in the default case. unistd.h from alpha is indeed exported.

If perf then on top of that uses some kernel internal
stuff - then pick it up there.
But having perf in the kernel is not an excuse for avoinding
the exported headers.

	Sam

  reply	other threads:[~2009-10-28 20:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-26  8:32 [PATCH] [alpha] Add minimal support for software performance events Michael Cree
2009-10-26  8:48 ` Ingo Molnar
2009-10-27  8:09   ` Michael Cree
2009-11-08 12:22     ` Ingo Molnar
2009-11-08 12:27       ` Ingo Molnar
2009-11-11  7:43         ` Michael Cree
2009-11-11  7:48           ` [tip:perf/core] perf tools: Test -fstack-protector-all compiler option for inclusion in CFLAGS tip-bot for Michael Cree
2009-10-27 18:29   ` [PATCH] [alpha] Add minimal support for software performance events Matt Turner
2009-10-28 20:56     ` Sam Ravnborg
2009-10-26 11:38 ` [tip:perf/core] perf tools, Alpha: Add Alpha support to perf.h tip-bot for Michael Cree
2009-10-26 12:08   ` Pekka Enberg
2009-10-26 12:22     ` Ingo Molnar
2009-10-28 20:58       ` Sam Ravnborg [this message]
2009-11-10 21:21     ` Peter Zijlstra
2009-12-01  4:30 ` [PATCH] [alpha] Add minimal support for software performance events Matt Turner
2009-12-01  9:31   ` Michael Cree

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091028205844.GC20363@merkur.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=hpa@zytor.com \
    --cc=ink@jurassic.park.msu.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mcree@orcon.net.nz \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=paulus@samba.org \
    --cc=penberg@cs.helsinki.fi \
    --cc=rth@twiddle.net \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®